Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix: use instance_id instead of item.id #19

Merged
merged 2 commits into from
Jun 27, 2023
Merged

fix: use instance_id instead of item.id #19

merged 2 commits into from
Jun 27, 2023

Conversation

ircwaves
Copy link
Contributor

Closes #18

Description:
The item.id strips away the underscores, but the instance_id is hanging out in the s3naming regex match object, so we can check there.

PR checklist:

  • Code is formatted (run scripts/format).
  • Code lints properly (run scripts/lint).
  • Tests pass (run scripts/test).
  • Documentation has been updated to reflect changes, if applicable.
  • Changes are added to the CHANGELOG.

@ircwaves ircwaves requested a review from pjhartzell June 27, 2023 21:15
@ircwaves ircwaves merged commit c9a0453 into stactools-packages:main Jun 27, 2023
@ircwaves ircwaves deleted the issue/18/count-some-underscores branch June 29, 2023 15:03
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@pjhartzell pjhartzell pjhartzell approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

slstr-lst strip (as opposed to "chips" or "frames") are not detected
2 participants
@ircwaves @pjhartzell