Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Adds a folder for Turing models, and a few models for testing, #262

Open
wants to merge 4 commits into
base: development
Choose a base branch
from

Conversation

JasonPekos
Copy link

Purpose

This PR adds a few Turing models:

Rationale

Eventually the rest of the Turing models are probably going to live here. For now, while I'm building out the Julia testing and benchmarking code, I'd like some models in the actual repository to test my code on.

These models cover some edge cases that I want to make sure my code covers.

@JasonPekos JasonPekos marked this pull request as draft June 20, 2024 16:56
@JasonPekos
Copy link
Author

Converting this to a draft — just noticed that I need to change the corresponding info files as well, to add a turing model section, e.g.:

(for the folder:)

  "model_implementations": {
    "stan": {
      "model_code": "models/stan/eight_schools_noncentered.stan",
      "stan_version": ">=2.26.0"
    },
    "pymc3": {
      "model_code": "models/pymc3/eight_schools_noncentered.py"
    },
    "turing": {
      "model_code": "models/turing/eight_schools_noncentered"
    }
  },

(for the actual code file:)

  "model_implementations": {
    "stan": {
      "model_code": "models/stan/eight_schools_noncentered.stan",
      "stan_version": ">=2.26.0"
    },
    "pymc3": {
      "model_code": "models/pymc3/eight_schools_noncentered.py"
    },
    "turing": {
      "model_code": "models/turing/eight_schools_noncentered/eight_schools_noncentered.jl"
    }
  },

not sure what is ideal here.

@JasonPekos JasonPekos marked this pull request as ready for review June 20, 2024 17:22
@JasonPekos
Copy link
Author

Ok, updated the .jsons to point at the actual julia files. will revisit if this is a problem. also unsure if adding new implementations for current models requires me to change anything else?

@MansMeg MansMeg changed the base branch from master to development June 21, 2024 09:20
@MansMeg
Copy link
Collaborator

MansMeg commented Jun 21, 2024

This looks good to me. I have two thoughts.

  1. We should probably add a document explaining how to run the Turing models. Ie example code, I guess an md in docs?
  2. hav you checked that these models give the same or proportional log density values as with stan?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants