Extend get_dims and get_param_names in model_base
#3139
Conversation
Expected behavior is to omit any size-0 objects
|
It seems like we have a bit of a chicken-egg problem here. If we delete the older function definition from We reach a happy state only after model_base is updated and stanc3 generates only one signature, I believe. @SteveBronder - thoughts? |
|
Jenkins passes when using stan-dev/stanc3#1245 up until the comparisons tests, which by definition can't run since the different versions can't use the same compiler output |
On the code side, probably nothing because of the default arguments, but at most two extra boolean arguments to So it's just a matter of whether it'll cause further complications with staging on CRAN for RStan and StanHeaders. |
|
All past models will have C++ code without those flags so somehow I would
have to avoid passing them in that situation.
|
|
OK... I was just worried about the rare need for binary compatibility in the model class, but it sounds as if we are good. |
|
@bgoodri: Can you avoid passing them? I couldn't tell if you were saying it would be OK for RStan or a problem. |
|
Thanks to some work by @serban-nicusor-toptal this is now able to pass all the tests including the performance tests when tested against stan-dev/stanc3#1245. I'd love to see this merged before the next release |
Submission Checklist
./runTests.py src/test/unitmake cpplintSummary
Closes stan-dev/stanc3#1240. New flags are added to these methods to allow excluding the tparams or generated quantities, and these are used in initialization.
Copyright and Licensing
Please list the copyright holder for the work you are submitting (this will be you or your assignee, such as a university or company):
Simons Foundation
By submitting this pull request, the copyright holder is agreeing to license the submitted work under the following licenses: