Skip to content
This repository has been archived by the owner on Nov 4, 2024. It is now read-only.

Use recommended semver i.e. release a v1.0.0 #116

Closed
mansona opened this issue Oct 3, 2017 · 1 comment
Closed

Use recommended semver i.e. release a v1.0.0 #116

mansona opened this issue Oct 3, 2017 · 1 comment
Labels

Comments

@mansona
Copy link

mansona commented Oct 3, 2017

Howdy 👋

I may have already said this but thanks a million for such an awesome module 👍

I want to open a discussion about bumping the current release to a v1.0.0 and to start following the recommended npm semver. In this discussion #66 there was a lot of talk about stabilising the APIs that are being used from node, and although I agree with the discussion and point of it I notice at the end you mention that "Please note I've changed some usage instructions." and released a minor version.

I am assuming that because the instructions have changed this is a breaking change? I have not yet tried it but I would imagine that it won't work for us because we are also doing something non standard #61

I understand that by "official" semver documentation any pre 1.0.0 minor release is considered a major breaking change, but I think this is "considered harmful" in the wider npm community. So much so that the official npm documentation states clearly "If a project is going to be shared with others, it should start at 1.0.0, though some projects on npm don't follow this rule."

I can't find a link to the original discussion but npm has now defaulted to version 1.0.0 for all newly init'ed modules since npm@2.0.0 3 years ago: https://github.com/npm/npm/releases/tag/v2.0.0

I think the sentiment from npm is that "integers are cheap" and there is nothing wrong with having a v6.0.0 of this esm loader 😄

@jdalton
Copy link
Member

jdalton commented Oct 3, 2017

Hi @mansona!

I understand that by "official" semver documentation any pre 1.0.0 minor release is considered a major breaking change

Yep, which is why I have it as a pre 1.0.0 release until it stabilizes (which should be soon).

I think the sentiment from npm is that "integers are cheap" and there is nothing wrong with having a v6.0.0 of this esm loader

I get it, I do. I'm going on v5 of Lodash. And like Lodash I started at a low pre-1.0 number. It gives a clear signal that things are still early and unstable. The loader should be ready for 1.0 in the next couple of weeks. Giving it time to bake is important because deps like Lodash, which impacts ~150,000 packages, will depend on it.

@jdalton jdalton closed this as completed Oct 3, 2017
github-actions bot pushed a commit to qiwi-forks/esm that referenced this issue Apr 13, 2021
# 1.0.0 (2021-04-13)

### Bug Fixes

* upadate dependencies. fix broken tests. ([696baf9](696baf9))
* **package:** update acorn to version 5.0.0 ([standard-things#97](https://github.com/qiwi-forks/esm/issues/97)) ([aefa703](aefa703))

### Reverts

* Revert "Switch from using mtime to ctime for cache validation. [closes standard-things#746]" ([376438c](376438c)), closes [standard-things#746](https://github.com/qiwi-forks/esm/issues/746)
* Revert "Remove SafeJSON." ([5947eb4](5947eb4))
* Revert "Only hoist function declarations." ([55d92f8](55d92f8))
* Revert "Temporarily remove chakracore/latest from appveyor test matrix." ([6968f58](6968f58))
* Revert "Remove unneeded package options cloning." [closes standard-things#504] ([7c22f88](7c22f88)), closes [standard-things#504](https://github.com/qiwi-forks/esm/issues/504)
* Revert "Remove ava from tips section." ([fbe713f](fbe713f))
* Revert "Remove refDestructuringErrors references from acorn plugins." ([c89e922](c89e922))
* Revert "Allow options.generateLegacyModuleImport to force legacy module.import." ([6bf5564](6bf5564)), closes [standard-things#116](https://github.com/qiwi-forks/esm/issues/116)
* Revert "Revert ast-types/fork changes to reinstate JSX types." ([6d5d4fd](6d5d4fd)), closes [standard-things#87](https://github.com/qiwi-forks/esm/issues/87)
* Revert "Move reify to peerDependencies of Babel plugin." ([428a632](428a632))
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
Development

No branches or pull requests

2 participants