-
Notifications
You must be signed in to change notification settings - Fork 147
Building on windows results in faulty package #87
Comments
Hi @laggingreflex! I can't repro. |
I'm on node 8.4 npm 5 I compared the Could you could you upload your Edit: Here's my version https://gist.github.com/laggingreflex/32140cf1bcdedfef6f23eaa3912f1a3e |
The build size difference is expected since our master branch is where WIP bits are. |
Tests are working, but can't use it outside the library for some reason. Setting the package version to 0.7.1 (from 0.7.0) and then building again solves the issue! Not sure why. I got this hint (of upgrading version) while debugging the webpack build. Somewhere the values being passed looked like this:
Edit: Don't know why I had version 0.7.0 to begin with. Maybe I had switched to a previous tag while testing. |
# 1.0.0 (2021-04-13) ### Bug Fixes * upadate dependencies. fix broken tests. ([696baf9](696baf9)) * **package:** update acorn to version 5.0.0 ([standard-things#97](https://github.com/qiwi-forks/esm/issues/97)) ([aefa703](aefa703)) ### Reverts * Revert "Switch from using mtime to ctime for cache validation. [closes standard-things#746]" ([376438c](376438c)), closes [standard-things#746](https://github.com/qiwi-forks/esm/issues/746) * Revert "Remove SafeJSON." ([5947eb4](5947eb4)) * Revert "Only hoist function declarations." ([55d92f8](55d92f8)) * Revert "Temporarily remove chakracore/latest from appveyor test matrix." ([6968f58](6968f58)) * Revert "Remove unneeded package options cloning." [closes standard-things#504] ([7c22f88](7c22f88)), closes [standard-things#504](https://github.com/qiwi-forks/esm/issues/504) * Revert "Remove ava from tips section." ([fbe713f](fbe713f)) * Revert "Remove refDestructuringErrors references from acorn plugins." ([c89e922](c89e922)) * Revert "Allow options.generateLegacyModuleImport to force legacy module.import." ([6bf5564](6bf5564)), closes [standard-things#116](https://github.com/qiwi-forks/esm/issues/116) * Revert "Revert ast-types/fork changes to reinstate JSX types." ([6d5d4fd](6d5d4fd)), closes [standard-things#87](https://github.com/qiwi-forks/esm/issues/87) * Revert "Move reify to peerDependencies of Babel plugin." ([428a632](428a632))
I'm on Windows and I tried to fork it and build it myself but building results in a package that always results in this error:
The text was updated successfully, but these errors were encountered: