Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Xianglei Zhu, 09/11/2021: FXT3p85_2018 and 09/14/2021: Isobar parameters #156

Merged
merged 2 commits into from
Nov 2, 2021

Conversation

fisyak
Copy link
Member

@fisyak fisyak commented Sep 27, 2021

Parameters for StTpcRSMaker for FXT3p85_2018 and Isobar_2017 obtained by Xianglei Zhu

Copy link
Member

@iraklic iraklic left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Since these are just parameters there isn't really much to approve.

@genevb
Copy link
Contributor

genevb commented Sep 27, 2021

@fisyak and @zhux97 (I'm guessing that's Xianglei's username on github, as there is little to go by in determining that), can either of you please comment on whether this is the full list of impacted productions, and the subsequent list of impacted libraries we need to consider?

  • FXT3p85_2018 => SL19e
  • Isobar => SL20c

Any other libraries? What about the rest of the BES-II productions (SL21c) and 2018 data productions (AuAu27 => SL19b)?

Thanks,
-Gene

@zhux97
Copy link
Contributor

zhux97 commented Sep 29, 2021

Hi Gene, Yes, so far, only the Run18 FXT3p85 and Isobar parameters have been tuned and checked, so SL19e and SL20c is the impacted libraries, respectively. Parameters for other datasets (like FXT26p5 and AuAu27) need some more work.

@klendathu2k
Copy link
Contributor

@plexoos @genevb @zhux97 @iraklic @fisyak I see that this PR has all checks passed and all approvals... but no one merged for 24 days. Is there a reason that it wasn't merged, or should I go ahead and press the shiny green button?

@iraklic
Copy link
Member

iraklic commented Nov 2, 2021

Hey @klendathu2k, I usually don't merge, but leave it to @plexoos :) In general, I think if one has merge privileges then one can merge... but @plexoos may correct me on this in case of STAR SW.

@plexoos
Copy link
Member

plexoos commented Nov 2, 2021

if one has merge privileges then one can merge

💯

@klendathu2k klendathu2k merged commit 60de80e into star-bnl:main Nov 2, 2021
@klendathu2k
Copy link
Contributor

Done.

jml985 pushed a commit that referenced this pull request Dec 7, 2021
…ers (#156)

* Xianglei Zhu, 09/11/2021: FXT3p85_2018 and 09/14/2021: Isobar parameters parameters

* Update StarDb/Calibrations/tpc/TpcResponseSimulator.20171220.000001.C

Co-authored-by: Dmitri Smirnov <dmixsmi@gmail.com>
marrbnl pushed a commit that referenced this pull request Dec 8, 2021
…ers (#156)

* Xianglei Zhu, 09/11/2021: FXT3p85_2018 and 09/14/2021: Isobar parameters parameters

* Update StarDb/Calibrations/tpc/TpcResponseSimulator.20171220.000001.C

Co-authored-by: Dmitri Smirnov <dmixsmi@gmail.com>
plexoos pushed a commit that referenced this pull request Dec 14, 2021
…ers (#156)

* Xianglei Zhu, 09/11/2021: FXT3p85_2018 and 09/14/2021: Isobar parameters parameters

* Update StarDb/Calibrations/tpc/TpcResponseSimulator.20171220.000001.C

Co-authored-by: Dmitri Smirnov <dmixsmi@gmail.com>
(cherry picked from commit 60de80e)
plexoos pushed a commit that referenced this pull request Dec 14, 2021
…ers (#156)

* Xianglei Zhu, 09/11/2021: FXT3p85_2018 and 09/14/2021: Isobar parameters parameters

* Update StarDb/Calibrations/tpc/TpcResponseSimulator.20171220.000001.C

Co-authored-by: Dmitri Smirnov <dmixsmi@gmail.com>
(cherry picked from commit 60de80e)
plexoos pushed a commit that referenced this pull request Dec 14, 2021
…ers (#156)

* Xianglei Zhu, 09/11/2021: FXT3p85_2018 and 09/14/2021: Isobar parameters parameters

* Update StarDb/Calibrations/tpc/TpcResponseSimulator.20171220.000001.C

Co-authored-by: Dmitri Smirnov <dmixsmi@gmail.com>
(cherry picked from commit 60de80e)
plexoos added a commit that referenced this pull request Jan 5, 2022
* Xianglei Zhu, 09/11/2021: FXT3p85_2018 and 09/14/2021: Isobar parameters (#156)

* Xianglei Zhu, 09/11/2021: FXT3p85_2018 and 09/14/2021: Isobar parameters parameters

* Update StarDb/Calibrations/tpc/TpcResponseSimulator.20171220.000001.C

Co-authored-by: Dmitri Smirnov <dmixsmi@gmail.com>
(cherry picked from commit 60de80e)

* Update gstar_part.g (#228)

updated the K0*(892) mass and width according to the latest PDG values.

(cherry picked from commit 2ff05cc)

Co-authored-by: Yuri Fisyak <fisyak@bnl.gov>
Co-authored-by: zhux97 <86642699+zhux97@users.noreply.github.com>
plexoos added a commit that referenced this pull request Jul 6, 2022
…time in eTOF (#372)

- Changing default start time modus in StEtofMatchMaker to use bTOF only start time instead of eTOF hybrid start time. 
- Added error hand-down from eTOF geometry to matchmaker if no alignment database table is found.

Additional notes:

This patch (PR #372) fixes a bug missed while introducing misalignment parameters for ETOF counters in PR #156
The code was reading a wrong number of entries from the database thus disabling the correction effect for all channels

Co-authored-by: Dmitri Smirnov <dmixsmi@gmail.com>
plexoos added a commit that referenced this pull request Jul 8, 2022
…time in eTOF (#372)

- Changing default start time modus in StEtofMatchMaker to use bTOF only start time instead of eTOF hybrid start time. 
- Added error hand-down from eTOF geometry to matchmaker if no alignment database table is found.

Additional notes:

This patch (PR #372) fixes a bug missed while introducing misalignment parameters for ETOF counters in PR #156
The code was reading a wrong number of entries from the database thus disabling the correction effect for all channels

Co-authored-by: Dmitri Smirnov <dmixsmi@gmail.com>
plexoos added a commit that referenced this pull request Jul 11, 2022
… ... (#376)

Fix misconfigured alignment correction in #358, change default start time in eTOF (#372)

- Changing default start time modus in StEtofMatchMaker to use bTOF only start time instead of eTOF hybrid start time. 
- Added error hand-down from eTOF geometry to matchmaker if no alignment database table is found.

Additional notes:

This patch (PR #372) fixes a bug missed while introducing misalignment parameters for ETOF counters in PR #156
The code was reading a wrong number of entries from the database thus disabling the correction effect for all channels

Co-authored-by: Dmitri Smirnov <dmixsmi@gmail.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

6 participants