Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[SL22b] Backport #372: Fix misconfigured alignment correction in #358, ... #376

Merged
merged 1 commit into from
Jul 11, 2022

Conversation

plexoos
Copy link
Member

@plexoos plexoos commented Jul 8, 2022

  • Changing default start time modus in StEtofMatchMaker to use bTOF only start time instead of eTOF hybrid start time.
  • Added error hand-down from eTOF geometry to matchmaker if no alignment database table is found.

Additional notes:

This patch (PR #372) fixes a bug missed while introducing misalignment parameters for ETOF counters in PR #156
The code was reading a wrong number of entries from the database thus disabling the correction effect for all channels

…time in eTOF (#372)

- Changing default start time modus in StEtofMatchMaker to use bTOF only start time instead of eTOF hybrid start time. 
- Added error hand-down from eTOF geometry to matchmaker if no alignment database table is found.

Additional notes:

This patch (PR #372) fixes a bug missed while introducing misalignment parameters for ETOF counters in PR #156
The code was reading a wrong number of entries from the database thus disabling the correction effect for all channels

Co-authored-by: Dmitri Smirnov <dmixsmi@gmail.com>
@plexoos
Copy link
Member Author

plexoos commented Jul 8, 2022

If you can think of any other reviewed changes we should patch SL22b with, please let me know.

@plexoos plexoos added the backport Label for backport changes applied to SLXXy branches label Jul 8, 2022
@plexoos plexoos merged commit 0836382 into SL22b Jul 11, 2022
@plexoos plexoos deleted the pr/backport/SL22b branch July 11, 2022 04:00
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
backport Label for backport changes applied to SLXXy branches
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants