Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Help cons figure out location of dependencies #357

Merged
merged 1 commit into from
May 26, 2022
Merged

Help cons figure out location of dependencies #357

merged 1 commit into from
May 26, 2022

Conversation

plexoos
Copy link
Member

@plexoos plexoos commented May 23, 2022

No description provided.

klendathu2k
klendathu2k approved these changes May 23, 2022
View reviewed changes
Copy link
Contributor

@klendathu2k klendathu2k left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks reasonable to me. I presume that, if anyone needs to compile / test with a specific fast jet or gsl or ... library, they can just set it up in their environment, and then the config scripts will do the rest.

@plexoos
Copy link
Member Author

plexoos commented May 23, 2022

Yes, when additional versions are available one can switch between them by adding a corresponding config scripts to PATH

genevb
genevb reviewed May 24, 2022
View reviewed changes
Copy link
Contributor

@genevb genevb left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

No objections.

@plexoos plexoos merged commit 726aedc into star-bnl:main May 26, 2022
@plexoos plexoos deleted the pr/cons_deps branch June 2, 2022 18:21
This was referenced Sep 22, 2022
Merged
Merged
Merged
plexoos added a commit that referenced this pull request Oct 2, 2022
@plexoos
cons: Use mysql_config to set up external dependency for mysql (#402)
be608cb 
When we configure the build with mysql as external dependency we can
fully rely on `mysql_config` found in PATH

This is similar to #357 where we also use `config` utilities to set up
`fastjet` and `gsl` packages.

[skip ci]
plexoos added a commit that referenced this pull request Oct 2, 2022
@plexoos
cons: Use xml2-config to set up external dependency (#404)
05ac703 
When we configure the build with xml2 as external dependency we can rely
on xml2-config found in PATH

This is similar to #357 where we
also use config utilities to set up fastjet and gsl packages and #402
for mysql

[skip ci]
plexoos added a commit that referenced this pull request Oct 2, 2022
@plexoos
cons: Use pkg-config to set up external dependency on log4cxx (#405)
bd9ca8e 
When we configure the build with log4cxx as external dependency we can
rely on pkg-config found in PATH

This is similar to #357 where we
also use config utilities to set up fastjet and gsl packages,
#402 for mysql, and #404 for
xml2
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@genevb genevb genevb left review comments

@klendathu2k klendathu2k klendathu2k approved these changes

@nigmatkulov nigmatkulov Awaiting requested review from nigmatkulov nigmatkulov is a code owner

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@plexoos @klendathu2k @genevb