Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

cons: Use xml2-config to set up external dependency #404

Merged
merged 3 commits into from
Oct 2, 2022

Conversation

plexoos
Copy link
Member

@plexoos plexoos commented Sep 22, 2022

When we configure the build with xml2 as external dependency we can rely on xml2-config found in PATH

This is similar to #357 where we also use config utilities to set up fastjet and gsl packages and #402 for mysql

@plexoos plexoos added the infrastructure Build environment and configuration label Sep 23, 2022
@plexoos plexoos added this to the SL22d milestone Sep 23, 2022
Copy link
Contributor

@klendathu2k klendathu2k left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Perfectly reasonable.

Copy link
Contributor

@genevb genevb left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

No objections.

@plexoos plexoos merged commit 05ac703 into star-bnl:main Oct 2, 2022
plexoos added a commit that referenced this pull request Oct 2, 2022
When we configure the build with log4cxx as external dependency we can
rely on pkg-config found in PATH

This is similar to #357 where we
also use config utilities to set up fastjet and gsl packages,
#402 for mysql, and #404 for
xml2
@plexoos plexoos deleted the pr/no_optstar_xml branch October 2, 2022 00:57
@plexoos plexoos modified the milestones: SL22d, SL23a Jan 4, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
infrastructure Build environment and configuration
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants