Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

ci: Enable more tests using star-test-data:v6 #415

Merged
merged 3 commits into from
Nov 3, 2022

Conversation

plexoos
Copy link
Member

@plexoos plexoos commented Oct 20, 2022

This enables three more tests (22, 23, and 24) running older production chains over 2005 and 2006 real data. The data for the tests is provided by the ghcr.io/star-bnl/star-test-data:v6 container

Test 20 is currently disabled due to an error, see opened issue at #425

@plexoos plexoos added the tests Changes affecting our automatic tests label Oct 20, 2022
@plexoos plexoos requested a review from veprbl as a code owner October 21, 2022 01:32
@plexoos plexoos marked this pull request as draft October 25, 2022 15:09
@plexoos plexoos force-pushed the pr/add_ci_tests branch 2 times, most recently from be79764 to 04bd928 Compare October 27, 2022 17:01
@plexoos
Copy link
Member Author

plexoos commented Oct 31, 2022

This PR is ready for a review. The currently failing test (24) will be taken care of by merging #427

@plexoos plexoos marked this pull request as ready for review October 31, 2022 14:48
This should allow us to see which tests do pass in case of a single
failure
@plexoos plexoos merged commit 632e54b into star-bnl:main Nov 3, 2022
@plexoos plexoos deleted the pr/add_ci_tests branch November 3, 2022 22:17
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
tests Changes affecting our automatic tests
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant