-
Notifications
You must be signed in to change notification settings - Fork 62
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Avoid pointer cast to time_t from incompatible type #427
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
If the proposed solution works for builds going forward, I have no objection to it.
Minor issue:
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks good to me.
Gene, do you know why we don't see this kind of problems with the 64-bit tests on the farm? |
The answer to my own question is that only a handful of the nightly tests on the farm use 64-bit libraries. By looking carefully at this summary page https://www.star.bnl.gov/devcgi/weekDEVjobStatus.pl one can notice a "_64bit" suffix added to the values in the Path column. Assuming these are the only tests for 64-bit builds, the failed test in CI due to the error reported in #426 is never executed on the farm. |
…35a267) Resolves star-bnl#426 cherry-pick 235a267
…35a267) Resolves star-bnl#426 cherry-pick 235a267
…35a267) Resolves star-bnl#426 cherry-pick 235a267
…35a267) Resolves star-bnl#426 cherry-pick 235a267
…35a267) Resolves star-bnl#426 cherry-pick 235a267
Resolves star-bnl#426 cherry-pick 235a267
Resolves #426