Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Avoid pointer cast to time_t from incompatible type #427

Merged
merged 2 commits into from
Nov 3, 2022

Conversation

plexoos
Copy link
Member

@plexoos plexoos commented Oct 28, 2022

Resolves #426

Copy link
Contributor

@genevb genevb left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

If the proposed solution works for builds going forward, I have no objection to it.

@veprbl
Copy link
Member

veprbl commented Oct 28, 2022

Minor issue:

#10 3672.1 .sl79_gcc485/OBJ/StRoot/StarRoot/TUnixTime.cxx: In member function 'TString TUnixTime::GetGString()':
[27021](https://github.com/star-bnl/star-sw/actions/runs/3347375021/jobs/5545286240#step:3:27024)
#10 3672.1 .sl79_gcc485/OBJ/StRoot/StarRoot/TUnixTime.cxx:135:3: error: 'time_t' is not a member of 'std'
[27022](https://github.com/star-bnl/star-sw/actions/runs/3347375021/jobs/5545286240#step:3:27025)
#10 3672.1    std::time_t utime = fUTime;
[27023](https://github.com/star-bnl/star-sw/actions/runs/3347375021/jobs/5545286240#step:3:27026)
#10 3672.1    ^

Copy link
Member

@starsdong starsdong left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good to me.

@plexoos
Copy link
Member Author

plexoos commented Oct 29, 2022

If the proposed solution works for builds going forward, I have no objection to it.

Gene, do you know why we don't see this kind of problems with the 64-bit tests on the farm?

@plexoos
Copy link
Member Author

plexoos commented Nov 3, 2022

If the proposed solution works for builds going forward, I have no objection to it.

Gene, do you know why we don't see this kind of problems with the 64-bit tests on the farm?

The answer to my own question is that only a handful of the nightly tests on the farm use 64-bit libraries. By looking carefully at this summary page https://www.star.bnl.gov/devcgi/weekDEVjobStatus.pl one can notice a "_64bit" suffix added to the values in the Path column. Assuming these are the only tests for 64-bit builds, the failed test in CI due to the error reported in #426 is never executed on the farm.

@plexoos plexoos merged commit 235a267 into star-bnl:main Nov 3, 2022
@plexoos plexoos deleted the pr/fix_time_t_cast branch November 3, 2022 13:43
@genevb
Copy link
Contributor

genevb commented Nov 3, 2022

the failed test in CI due to the error reported in #426 is never executed on the farm.

Thanks for doing the investigative work, @plexoos

plexoos added a commit to plexoos/star-sw that referenced this pull request Dec 15, 2022
plexoos added a commit to plexoos/star-sw that referenced this pull request Dec 16, 2022
plexoos added a commit that referenced this pull request Dec 18, 2022
plexoos added a commit to plexoos/star-sw that referenced this pull request Dec 20, 2022
plexoos added a commit that referenced this pull request Dec 21, 2022
plexoos added a commit that referenced this pull request Feb 1, 2023
plexoos added a commit that referenced this pull request Feb 2, 2023
plexoos added a commit to plexoos/star-sw that referenced this pull request May 9, 2023
plexoos added a commit to zhux97/star-sw that referenced this pull request May 10, 2023
plexoos added a commit that referenced this pull request May 10, 2023
plexoos added a commit to plexoos/star-sw that referenced this pull request Feb 19, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Invalid cast between incompatible types for std::gmtime argument
6 participants