Update to trigger simulator to save intermediate jet patch ADCs and minor cleanup to the jet maker

[zlchang]

1. Update to the trigger simulator to save the intermediate jet patch sum ADCs and make them available to access for analysis. In this case save the 30 jet patch ADCs in the StJetSkimEvent.
2. Remove unnecessary printouts in the StJetMaker2012 during the UE offaxis cone calculation

Not urgent! May add additional edits if necessary.

[klendathu2k]

This change presumes that jpx y and z can be negative. Are these jetpatch sums? If so, can they actually be negative? Looking at the code does not make that obvious to me. You only increment by values which I presume are all expected to be positive.

[zlchang]

Hi Jason, yes these are jet patch adc sums. They are 6-bit integers, so it doesn't matter if it's int or unsigned int.

[plexoos]

Not urgent! May add additional edits if necessary.

You can mark it as draft until it's ready. Also, could you please give it a concise title and put details in the description? By default the final commit will inherit that from the PR when we squash and merge. Thanks

[zlchang]

Hi guys, any comment on this request?

[plexoos]

Hi guys, any comment on this request?

Did you see the comment from Jason?
Can you change the title of this PR as suggested?

[zlchang]

1. Update to the trigger simulator to save the intermediate jet patch sum ADCs and make them available to access for analysis. In this case save the 30 jet patch ADCs in the StJetSkimEvent. 2) Remove unnecessary printouts in the StJetMaker2012 during the UE offaxis cone calculation

[plexoos]

Unrelated to this PR but related to the modified files you are the owner of. There is a bunch of compiler warnings coming from StRoot/StTriggerUtilities/Bemc/StBemcTriggerSimu.cxx and StRoot/StTriggerUtilities/Eemc/StEemcTriggerCompare.cxx. Could you please address them in a separate PR?

[zlchang]

Okay I will look at the warning message and try to correct them.

Unrelated to this PR but related to the modified files you are the owner of. There is a bunch of compiler warnings coming from StRoot/StTriggerUtilities/Bemc/StBemcTriggerSimu.cxx and StRoot/StTriggerUtilities/Eemc/StEemcTriggerCompare.cxx. Could you please address them in a separate PR?

[zlchang]

Any comments or suggestions, @akioogawa @jml985 and @veprbl

[veprbl]

Sorry for the delay! I must admit, I have no idea what issue are you trying to resolve here. Was this presented anywhere? How one can see what isn't going right without it? Are any of the existing analyses affected?

[zlchang]

Hi Akio @akioogawa and Jeff @jml985, any comment or question? In case you missed it, I also presented this update to our cold qcd group. https://drupal.star.bnl.gov/STAR/system/files/run17trgSimu.pdf

[plexoos]

If you don't get a response from the nominal code owners in a reasonable time, just let us know here and we'll merge.

[starsdong]

Dmitri, I would suggest to merge this one after this branch is synced with the main. Thanks

[starsdong]

Zilong, could you please update your branch to be sync with main? Then after the CI checks out, let us merge this PR then. Thanks

[plexoos]

Xin, are you approving this PR?

[zlchang]

Hi Xin and Dmitry, I think it is the time to merge the pull request into the main. I also come up with a few fixes to suppress the warning messages from StBemcSimuMaker and StEemcTriggerCompare that Dmitry had mentioned before. I can put them in this request or I can submit another request. Let me know which option is better for you. Zilong On Dec 6, 2022, at 8:55 PM, Dmitri Smirnov ***@***.***> wrote:  Xin, are you approving this PR? — Reply to this email directly, view it on GitHub<#424 (comment)>, or unsubscribe<https://github.com/notifications/unsubscribe-auth/AGH7F3MMOP2S3OYYSRPLYHDWL7VAPANCNFSM6AAAAAARQPHJII>. You are receiving this because you authored the thread.Message ID: ***@***.***>

[plexoos]

Hi Zilong, Yes, please address compiler warnings in another pull request as we discussed. Thank you.