Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Update to trigger simulator to save intermediate jet patch ADCs and minor cleanup to the jet maker #424
Update to trigger simulator to save intermediate jet patch ADCs and minor cleanup to the jet maker #424
Changes from all commits
1878d43
7ca0ac9
4cc3983
5d50d0a
4896442
c69c9f5
c6ca14d
0aa784a
b251aae
92e210d
dd7151c
b1d2947
f410218
File filter
Filter by extension
Conversations
Jump to
There are no files selected for viewing
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This change presumes that jpx y and z can be negative. Are these jetpatch sums? If so, can they actually be negative? Looking at the code does not make that obvious to me. You only increment by values which I presume are all expected to be positive.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Hi Jason, yes these are jet patch adc sums. They are 6-bit integers, so it doesn't matter if it's int or unsigned int.