build: backport CI machinery from SL23a_0 #540
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
``` git diff SL20c_2..SL23a_0 -- docker/ .github/workflows/ Dockerfile tests/ asps/rexe/Cons* asps/rexe/*LinkDef* mgr/Cons* mgr/config/ StRoot/macros/rootlogo*.C StRoot/macros/.rootrc > patch.diff git am < patch.diff ```
Since this is done manually for the the generated classes (`StarGeometry` and `Geometry`), we need to turn off the automatic dictionary generation in `StarVMC/Geometry` triggered otherwise by the `StarGeoLinkDef.h` file. cherry-pick 8378339
plexoos
added
backport
…35a267) Resolves star-bnl#426 cherry-pick 235a267
|
To provide context for the changes discussed earlier in the meeting, most of the modifications in this PR can be found in https://github.com/star-bnl/star-sw/pull/540/files. These changes backport recent updates (specifically from SL23a_0) to enable the build system to function within the containerized environment used in CI and ensure the tests pass. During testing, we found that several tests failed initially due to an error in StPicoDstMaker. Specifically, the error message "StPicoDstMaker:ERROR - Pico Vertex Mode is not set" was encountered in the following tests: The issue could be resolved by pulling the following two commits from Gene and Grigory: c274452 and 3f17703, respectively. However, it's worth noting that SL20c may have never been used to run these jobs. As an alternative solution, we could completely exclude the failing tests. |
|
Thanks for the list of jobs, Dmitri. I do believe these jobs were never run in SL20c, and my preference would be (or is it too late?) not to backport the patches and instead exclude those test jobs from the SL20c CI as a general guideline for handling such cases. But given how inconsequential the patches are, I'm not going to worry about it if we just move forward with including the patches. It's fine.
…-Gene
On May 10, 2023, at 1:19 PM, Dmitri Smirnov ***@***.***> wrote:
To provide context for the changes discussed earlier in the meeting, most of the modifications in this PR can be found in https://github.com/star-bnl/star-sw/pull/540/files. These changes backport recent updates (specifically from SL23a_0) to enable the build system to function within the containerized environment used in CI and ensure the tests pass.
During testing, we found that several tests failed initially due to an error in StPicoDstMaker. Specifically, the error message "StPicoDstMaker:ERROR - Pico Vertex Mode is not set" was encountered in the following tests:
bfc.C(2000, "P2020a,StiCA,btof,mtd,etofA,BEmcChkStat,picoVtxDefault,PicoVtxFXT,PicoCovMtxWrite,-beamline3D,-hitfilt,QAalltrigs", "/star/rcf/test/daq/2020/028/st_physics_21028024_raw_1500008.daq")
bfc.C(2000, "P2020a,btof,mtd,etofA,BEmcChkStat,picoVtxDefault,PicoVtxFXT,PicoCovMtxWrite,-beamline3D,-hitfilt,QAalltrigs", "/star/rcf/test/daq/2020/028/st_physics_21028024_raw_1500008.daq")
bfc.C(2000, "P2020a,StiCA,btof,mtd,etofA,BEmcChkStat,picoVtxDefault,PicoVtxFXT,PicoCovMtxWrite,-beamline3D,-hitfilt,QAalltrigs", "/star/rcf/test/daq/2020/032/st_physics_21032055_raw_1500015.daq")
bfc.C(2000, "P2020a,btof,mtd,etofA,BEmcChkStat,picoVtxDefault,PicoVtxFXT,PicoCovMtxWrite,-beamline3D,-hitfilt,QAalltrigs", "/star/rcf/test/daq/2020/032/st_physics_21032055_raw_1500015.daq")
bfc.C(2000, "P2020a,StiCA,btof,mtd,etofA,BEmcChkStat,picoVtxDefault,PicoVtxFXT,PicoCovMtxWrite,-beamline3D,-hitfilt,QAalltrigs", "/star/rcf/test/daq/2020/035/st_physics_21035026_raw_1500009.daq")
bfc.C(2000, "P2020a,btof,mtd,etofA,BEmcChkStat,picoVtxDefault,PicoVtxFXT,PicoCovMtxWrite,-beamline3D,-hitfilt,QAalltrigs", "/star/rcf/test/daq/2020/035/st_physics_21035026_raw_1500009.daq")
The issue could be resolved by pulling the following two commits from Gene and Grigory: c274452 and 3f17703, respectively.
However, it's worth noting that SL20c may have never been used to run these jobs. As an alternative solution, we could completely exclude the failing tests.
cc @fgeurts @genevb
—
Reply to this email directly, view it on GitHub, or unsubscribe.
You are receiving this because you were mentioned.
|
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.