-
Notifications
You must be signed in to change notification settings - Fork 290
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
fix issue 3703, add more validation and more error display #3722
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
add more validation when create AccountPrivateKeyProvider add more error display in deploying
JerryKwan
requested review from
nanne007,
templexxx and
jolestar
as code owners
September 7, 2022 03:43
Codecov Report
@@ Coverage Diff @@
## master #3722 +/- ##
==========================================
+ Coverage 55.25% 55.71% +0.47%
==========================================
Files 597 597
Lines 64366 64377 +11
==========================================
+ Hits 35559 35864 +305
+ Misses 28807 28513 -294
Flags with carried forward coverage won't be shown. Click here to find out more.
Continue to review full report at Codecov.
|
jolestar
reviewed
Sep 7, 2022
reformat code according suggestions
remove address and private key validation when creating AccountPrivateKeyProvider
change line separator
jolestar
approved these changes
Sep 7, 2022
jiangying000
pushed a commit
to jiangying000/starcoin
that referenced
this pull request
Sep 8, 2022
…rg#3722) * add more validation and more error display add more validation when create AccountPrivateKeyProvider add more error display in deploying * reformat code according suggestions reformat code according suggestions * remove address and private key validation remove address and private key validation when creating AccountPrivateKeyProvider * change line separator change line separator Co-authored-by: JerryKwan <Jinzhong.Guan@gmailcom>
jiangying000
pushed a commit
to jiangying000/starcoin
that referenced
this pull request
Sep 8, 2022
…rg#3722) * add more validation and more error display add more validation when create AccountPrivateKeyProvider add more error display in deploying * reformat code according suggestions reformat code according suggestions * remove address and private key validation remove address and private key validation when creating AccountPrivateKeyProvider * change line separator change line separator Co-authored-by: JerryKwan <Jinzhong.Guan@gmailcom>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
add more validation when create AccountPrivateKeyProvider add more error display in deploying
Pull request type
Please check the type of change your PR introduces:
What is the current behavior?
Issue Number: #3703
What is the new behavior?
It will do more validation when creating AccountPrivateKeyProvider and will display show dry run result and displays the result of build_and_execute_transaction if necessary to facilitate debugging.
Other information