Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix issue 3703, add more validation and more error display #3722

Merged
merged 4 commits into from
Sep 7, 2022

Conversation

JerryKwan
Copy link
Contributor

add more validation when create AccountPrivateKeyProvider add more error display in deploying

Pull request type

Please check the type of change your PR introduces:

  • Bugfix
  • Feature
  • Code style update (formatting, renaming)
  • Refactoring (no functional changes, no api changes)
  • Build related changes
  • Documentation content changes
  • Other (please describe):

What is the current behavior?

Issue Number: #3703

What is the new behavior?

It will do more validation when creating AccountPrivateKeyProvider and will display show dry run result and displays the result of build_and_execute_transaction if necessary to facilitate debugging.

Other information

add more validation when create AccountPrivateKeyProvider
add more error display in deploying
@codecov
Copy link

codecov bot commented Sep 7, 2022

Codecov Report

Merging #3722 (fc0e154) into master (9e071d3) will increase coverage by 0.47%.
The diff coverage is 0.00%.

Impacted file tree graph

@@            Coverage Diff             @@
##           master    #3722      +/-   ##
==========================================
+ Coverage   55.25%   55.71%   +0.47%     
==========================================
  Files         597      597              
  Lines       64366    64377      +11     
==========================================
+ Hits        35559    35864     +305     
+ Misses      28807    28513     -294     
Flag Coverage Δ
unittests 55.71% <0.00%> (+0.47%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

Impacted Files Coverage Δ
cmd/starcoin/src/cli_state.rs 15.66% <0.00%> (-0.15%) ⬇️
vm/move-package-manager/src/deployment.rs 0.00% <0.00%> (ø)
commons/timeout-join-handler/src/lib.rs 70.84% <0.00%> (-2.08%) ⬇️
commons/stest/src/lib.rs 90.39% <0.00%> (-1.92%) ⬇️
...ync/src/block_connector/block_connector_service.rs 51.67% <0.00%> (-1.66%) ⬇️
sync/src/tasks/accumulator_sync_task.rs 96.16% <0.00%> (-1.28%) ⬇️
...ons/forkable-jellyfish-merkle/src/node_type/mod.rs 91.44% <0.00%> (-0.55%) ⬇️
chain/src/chain.rs 67.10% <0.00%> (-0.12%) ⬇️
vm/starcoin-transactional-test-harness/src/lib.rs 0.12% <0.00%> (ø)
network-p2p/peerset/src/peersstate.rs 85.98% <0.00%> (+0.21%) ⬆️
... and 27 more

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 9e071d3...fc0e154. Read the comment docs.

JerryKwan added 3 commits September 6, 2022 23:30
reformat code according suggestions
remove address and private key validation when creating AccountPrivateKeyProvider
change line separator
@jolestar jolestar merged commit d61d81d into starcoinorg:master Sep 7, 2022
jiangying000 pushed a commit to jiangying000/starcoin that referenced this pull request Sep 8, 2022
…rg#3722)

* add more validation and more error display

add more validation when create AccountPrivateKeyProvider
add more error display in deploying

* reformat code according suggestions

reformat code according suggestions

* remove address and private key validation

remove address and private key validation when creating AccountPrivateKeyProvider

* change line separator

change line separator

Co-authored-by: JerryKwan <Jinzhong.Guan@gmailcom>
jiangying000 pushed a commit to jiangying000/starcoin that referenced this pull request Sep 8, 2022
…rg#3722)

* add more validation and more error display

add more validation when create AccountPrivateKeyProvider
add more error display in deploying

* reformat code according suggestions

reformat code according suggestions

* remove address and private key validation

remove address and private key validation when creating AccountPrivateKeyProvider

* change line separator

change line separator

Co-authored-by: JerryKwan <Jinzhong.Guan@gmailcom>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[Bug Report]wrong prompt when deploying package with secret-file belongs to another address
2 participants