Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix issue 3703, add more validation and more error display #3722

Merged
merged 4 commits into from
Sep 7, 2022
Merged

fix issue 3703, add more validation and more error display #3722

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
4 commits
Select commit Hold shift + click to select a range
e258cdf
add more validation and more error display
Sep 7, 2022
1855242
reformat code according suggestions
Sep 7, 2022
4521096
remove address and private key validation
Sep 7, 2022
fc0e154
change line separator
Sep 7, 2022
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
1 change: 1 addition & 0 deletions Cargo.lock
View file
Open in desktop

Some generated files are not rendered by default. Learn more about how customized files appear on GitHub.

5 changes: 4 additions & 1 deletion cmd/starcoin/src/cli_state.rs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -287,7 +287,10 @@ impl CliState {
TransactionStatusView::Executed
)
{
eprintln!("txn dry run result:");
eprintln!(
"txn dry run result: {:?}",
execute_result.dry_run_output.txn_output
);
return Ok(execute_result);
}

Expand Down
1 change: 1 addition & 0 deletions vm/move-package-manager/Cargo.toml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -63,6 +63,7 @@ starcoin-types = {path = "../../types"}
starcoin-vm-runtime = {path = "../vm-runtime", features = ["testing"]}
starcoin-vm-types = {path = "../../vm/types"}
stdlib = {path = "../stdlib"}
vm-status-translator = {path = "../../vm/vm-status-translator"}

[dev-dependencies]

Expand Down
12 changes: 11 additions & 1 deletion vm/move-package-manager/src/deployment.rs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -14,6 +14,7 @@ use starcoin_rpc_client::RpcClient;
use starcoin_vm_types::transaction::TransactionPayload;
use std::path::PathBuf;
use std::time::Duration;
use vm_status_translator::VmStatusExplainView;

#[derive(Parser)]
pub struct DeploymentCommand {
Expand Down Expand Up @@ -102,7 +103,16 @@ pub fn handle_deployment(_move_args: &Move, cmd: DeploymentCommand) -> anyhow::R
let item =
state.build_and_execute_transaction(cmd.txn_opts, TransactionPayload::Package(package));
match item {
Ok(_) => println!("The deployment is successful."),
Ok(execute_result_view) => {
// check dry run result
if VmStatusExplainView::Executed == execute_result_view.dry_run_output.explained_status
{
println!("The deployment is successful.");
} else {
println!("The deployment is failed. execute result view is: ");
println!("{:?}", execute_result_view);
}
}
Err(e) => {
println!("The deployment is failed. Reason: ");
println!("{:?}", e);
Expand Down