Run the pre-commit hooks in a github action #12
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
vivodi
reviewed
Jul 26, 2025
| steps: | ||
| - uses: actions/checkout@v4 | ||
| - uses: actions/setup-python@v5 | ||
| - uses: pre-commit/action@v3.0.1 |
Contributor
There was a problem hiding this comment.
pre-commit/action is in maintenance-only mode and is much slower than the pre-commit.ci GitHub app.
pre-commit/action also doesn't support automatic fixes, — even when using the --fix option, the corrections can't be written back to the corresponding PR or branch.
datastar-python/.pre-commit-config.yaml
Lines 7 to 8 in f5ecafd
Why not use the pre-commit.ci GitHub app instead?
Collaborator
Author
There was a problem hiding this comment.
I'm not an admin here to enable it. The GitHub action will remind people to run the checks locally though.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.