Skip to content

Run the pre-commit hooks in a github action #12

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Jul 21, 2025
Merged

Run the pre-commit hooks in a github action #12

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
14 changes: 14 additions & 0 deletions .github/workflows/pre-commit.yaml
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -0,0 +1,14 @@
name: pre-commit

on:
pull_request:
push:
branches: [main]

jobs:
pre-commit:
runs-on: ubuntu-latest
steps:
- uses: actions/checkout@v4
- uses: actions/setup-python@v5
- uses: pre-commit/action@v3.0.1
Copy link
Contributor

@vivodi vivodi Jul 26, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

pre-commit/action is in maintenance-only mode and is much slower than the pre-commit.ci GitHub app.

pre-commit/action also doesn't support automatic fixes, — even when using the --fix option, the corrections can't be written back to the corresponding PR or branch.

datastar-python/.pre-commit-config.yaml

Lines 7 to 8 in f5ecafd

- id: ruff-check
args: [ --fix ]

Why not use the pre-commit.ci GitHub app instead?

Copy link
Collaborator Author

@gazpachoking gazpachoking Jul 26, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I'm not an admin here to enable it. The GitHub action will remind people to run the checks locally though.

Loading