Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update StarFive U-Boot to work with upstream OpenSBI generic platform #17

Merged
merged 2 commits into from
Jun 3, 2021
Merged

Conversation

lbmeng
Copy link
Collaborator

@lbmeng lbmeng commented Jun 2, 2021

This addresses starfive-tech/opensbi#4

Tested with:

  • OpenSBI commit 54d7def ("lib: utils: Try other FDT drivers when we see SBI_ENODEV")
  • dtb built from StarFive U-Boot repo

lbmeng added 2 commits June 2, 2021 16:26
… ONLY)"

This reverts commit 1b36682.

The SiFive CLINT driver is supposed to work in M-mode only.

Signed-off-by: Bin Meng <bmeng.cn@gmail.com>
As we are running in S-mode, RISCV_TIMER has to be used.
Adjust the config file accordingly.

Signed-off-by: Bin Meng <bmeng.cn@gmail.com>
@esmil
Copy link

esmil commented Jun 2, 2021

I've installed upstream OpenSBI and this (built by @atishp04) on my board and so far I haven't seen the issue in starfive-tech/linux#15 even though OpenSBI has choosen both hart 0 and hart 1 as boot hart.

@lbmeng Thanks!

@lbmeng
Copy link
Collaborator Author

lbmeng commented Jun 3, 2021

Thanks @esmil for the confirmation. @pdp7 I am going to merge this. Do you see any problems?

@pdp7
Copy link
Collaborator

pdp7 commented Jun 3, 2021

@tekkamanninja can we merge this?

@lbmeng
Copy link
Collaborator Author

lbmeng commented Jun 3, 2021

I seem to have the privilege to click the button so if everyone agrees, I can do the merge.

@lbmeng
Copy link
Collaborator Author

lbmeng commented Jun 3, 2021

Based on test results from @esmil, @kraj and @mcd500, I will merge this PR now.

@lbmeng lbmeng merged commit 93099a6 into starfive-tech:Fedora_VIC_7100_2021.04 Jun 3, 2021
@lbmeng lbmeng deleted the upstream_opensbi branch June 3, 2021 05:07
@lbmeng lbmeng self-assigned this Jun 3, 2021
esmil referenced this pull request in starfive-tech/linux Aug 11, 2021
This adds a combined pinctrl and gpio driver for the StarFive Ltd.
JH7100 RISC-V SoC [1].

For each "GPIO" there are two registers for configuring the output and
output enable signals, which may come from other peripherals, and
controlling the GPIOs from software amounts to setting these signals
to constant 0 or constant 1. In other words the same registers are used
for both pinmuxing and controlling the GPIOs, which makes it easier to
combine the pinctrl and gpio driver in one.

The gpio code is adapted from the gpio driver in the vendor tree written
by Huan Feng with cleanups and fixes by Drew and me.

[1] https://github.com/starfive-tech/beaglev_doc

Signed-off-by: Emil Renner Berthing <kernel@esmil.dk>
Signed-off-by: Huan Feng <huan.feng@starfivetech.com>
Signed-off-by: Drew Fustini <drew@beagleboard.org>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants