Added add and sub for i*.

[orizi]

Stack:

• Added implementation for i128 mul. #3625
• Added Neg operator for i*. #3624
• Added cast for signed integers. #3623
• Added i*_diff and Ord. #3622
• Added i*_mul op. #3621
• Added add and sub for i*. #3620 ⬅

⚠️ Part of a stack created by spr. Do not merge manually using the UI - doing so may have unexpected results.

---

This change is 

[spapinistarkware]

Reviewed 1 of 16 files at r1.
Reviewable status: 0 of 16 files reviewed, 1 unresolved discussion (waiting on @orizi)

---

corelib/src/test/integer_test.cairo line 1142 at r2 (raw file):

    assert_eq(@(-121_i8 - -21_i8), @-100_i8, '-121--21=-100');
}

Please check sub overflow and add underflow

[spapinistarkware]

Reviewable status: 0 of 16 files reviewed, 3 unresolved discussions (waiting on @orizi)

---

crates/cairo-lang-sierra-to-casm/src/invocations/int/signed.rs line 122 at r3 (raw file):

        jump IsInRange if is_in_range != 0;
        tempvar is_overflow;
        hint TestLessThan {lhs: value, rhs: range_size} into {dst: is_overflow};

value might be up to 2*MAX, but you check here value <= MAX-MIN. This works if MIN=-MAX-1, but this assumption should be added to the documentation somewhere, so we won't try to use it for weird ranges.

---

crates/cairo-lang-sierra-to-casm/src/invocations/int/signed.rs line 124 at r3 (raw file):

        hint TestLessThan {lhs: value, rhs: range_size} into {dst: is_overflow};
        jump IsOverflow if is_overflow != 0;
    // IsUnderflow:

Remove or indent

[spapinistarkware]

Reviewed 7 of 16 files at r1, 8 of 8 files at r2, 1 of 1 files at r3, all commit messages.
Reviewable status: all files reviewed, 3 unresolved discussions (waiting on @orizi)

[orizi]

Reviewable status: all files reviewed, 3 unresolved discussions (waiting on @spapinistarkware)

---

corelib/src/test/integer_test.cairo line 1142 at r2 (raw file):

Previously, spapinistarkware (Shahar Papini) wrote…

Please check sub overflow and add underflow

Done.

[orizi]

Reviewable status: 13 of 16 files reviewed, 3 unresolved discussions (waiting on @spapinistarkware)

---

crates/cairo-lang-sierra-to-casm/src/invocations/int/signed.rs line 122 at r3 (raw file):

Previously, spapinistarkware (Shahar Papini) wrote…

value might be up to 2*MAX, but you check here value <= MAX-MIN. This works if MIN=-MAX-1, but this assumption should be added to the documentation somewhere, so we won't try to use it for weird ranges.

do you mean that this only works for MIN <= 0 && MAX-MIN < 2**128?
because otherwise i'm not sure i understand.
Added asserts for this.

---

crates/cairo-lang-sierra-to-casm/src/invocations/int/signed.rs line 124 at r3 (raw file):

Previously, spapinistarkware (Shahar Papini) wrote…

Remove or indent

Done.

[spapinistarkware]

Reviewed 1 of 2 files at r4, 1 of 2 files at r5, 5 of 5 files at r6, all commit messages.
Reviewable status: complete! all files reviewed, all discussions resolved (waiting on @orizi)