-
Notifications
You must be signed in to change notification settings - Fork 564
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Added implementation for i128 mul. #3625
Conversation
c62248d
to
98fdd32
Compare
7938e3e
to
8342c29
Compare
36ff4ae
to
845a654
Compare
8342c29
to
d5f14d2
Compare
11f24fb
to
f32e14b
Compare
569b388
to
9cab5e9
Compare
9cab5e9
to
a7a3bec
Compare
73bc500
to
d18e11a
Compare
c9791f3
to
789e8a2
Compare
242b294
to
4dd7982
Compare
3597c00
to
62dab2e
Compare
40c8bb2
to
cbef09f
Compare
6439e21
to
d55c716
Compare
d55c716
to
66417d5
Compare
2473110
to
764ce61
Compare
66417d5
to
1f0229b
Compare
f4b7e64
to
c8ea4a3
Compare
c8ea4a3
to
66e6d1a
Compare
66e6d1a
to
1646e59
Compare
1646e59
to
b552afc
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Reviewed 2 of 2 files at r1, all commit messages.
Reviewable status: all files reviewed, 2 unresolved discussions (waiting on @orizi and @spapinistarkware)
corelib/src/test/integer_test.cairo
line 1745 at r1 (raw file):
assert_eq(@(-3_i128 - -1_i128), @-2_i128, '-3 - -1 == -2'); assert_eq(@(-231_i128 - -131_i128), @-100_i128, '-231--131=-100'); assert_eq(@(1_i128 * 3_i128), @3_i128, '1 * 3 == 3');
Consider adding a 1*0
test case.
corelib/src/test/integer_test.cairo
line 1748 at r1 (raw file):
assert_eq(@(2_i128 * 4_i128), @8_i128, '2 * 4 == 8'); assert_eq(@(-1_i128 * 3_i128), @-3_i128, '-1 * 3 == 3'); assert_eq(@(-2_i128 * 4_i128), @-8_i128, '-2 * 4 == 8');
Suggestion:
assert_eq(@(-1_i128 * 3_i128), @-3_i128, '-1 * 3 == -3');
assert_eq(@(-2_i128 * 4_i128), @-8_i128, '-2 * 4 == -8');
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Reviewable status: all files reviewed, 2 unresolved discussions (waiting on @orizi and @spapinistarkware)
commit-id:e5ea59f5
b552afc
to
1581e78
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Reviewed 2 of 2 files at r2, all commit messages.
Reviewable status: all files reviewed, 2 unresolved discussions (waiting on @orizi and @spapinistarkware)
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Reviewed 1 of 2 files at r2, all commit messages.
Reviewable status: complete! all files reviewed, all discussions resolved (waiting on @spapinistarkware)
Stack:
This change is