-
Notifications
You must be signed in to change notification settings - Fork 545
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Added WideSquare
trait.
#6194
Added WideSquare
trait.
#6194
Conversation
abeb7b8
to
4d24ee3
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Reviewed 5 of 5 files at r1, all commit messages.
Reviewable status: complete! all files reviewed, all discussions resolved (waiting on @orizi)
4d24ee3
to
1c17123
Compare
1c17123
to
6786aab
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Reviewed 1 of 1 files at r2, all commit messages.
Reviewable status: complete! all files reviewed, all discussions resolved (waiting on @orizi)
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Reviewable status: all files reviewed, 1 unresolved discussion (waiting on @orizi)
corelib/src/num/traits/ops/widepow2.cairo
line 4 at r2 (raw file):
/// A trait for a type that can be squared to produce a wider type. pub trait WidePow2<T> {
WideSqr
. Pow2 is 2**x
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Reviewed all commit messages.
Reviewable status: all files reviewed, 1 unresolved discussion (waiting on @orizi)
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Reviewable status: all files reviewed, 1 unresolved discussion (waiting on @liorgold2)
corelib/src/num/traits/ops/widepow2.cairo
line 4 at r2 (raw file):
Previously, liorgold2 wrote…
WideSqr
. Pow2 is2**x
WideSqr
anywhere i found on the internet was still a square root.
more options?
57a3a8a
to
ccebb3f
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Reviewable status: 1 of 5 files reviewed, all discussions resolved (waiting on @gilbens-starkware)
corelib/src/num/traits/ops/widepow2.cairo
line 4 at r2 (raw file):
Previously, orizi wrote…
WideSqr
anywhere i found on the internet was still a square root.more options?
WideSquare
is good
(BTW, from what I know sqr
is square, sqrt
is square root.)
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Reviewable status: 1 of 5 files reviewed, all discussions resolved (waiting on @gilbens-starkware)
corelib/src/num/traits/ops/widepow2.cairo
line 4 at r2 (raw file):
Previously, liorgold2 wrote…
WideSquare
is good
(BTW, from what I knowsqr
is square,sqrt
is square root.)
in general - true.
in microsoft SQL - Sqr == Square root :(
(and that was the only thing i actually found looking around).
Allowing optimized implementaion of WideMul squaring. commit-id:77870a43
ccebb3f
to
8c24505
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Reviewed 4 of 4 files at r3, all commit messages.
Reviewable status: complete! all files reviewed, all discussions resolved (waiting on @liorgold2)
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Reviewable status: complete! all files reviewed, all discussions resolved (waiting on @liorgold2)
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Reviewed all commit messages.
Reviewable status: complete! all files reviewed, all discussions resolved (waiting on @orizi)
Allowing optimized implementaion of WideMul squaring.
This change is