Using default implementations for PartialOrd::{gt,le,ge}.
#6195
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This was referenced Aug 12, 2024
orizi
force-pushed
the
pr/orizi/num-updates/8f9766c2
branch
from
28ea718 to
4e97ed2
Compare
orizi
force-pushed
the
pr/orizi/num-updates/77870a43
branch
from
abeb7b8 to
4d24ee3
Compare
gilbens-starkware
approved these changes
Aug 12, 2024
There was a problem hiding this comment.
Reviewed 4 of 4 files at r1, all commit messages.
Reviewable status:complete! all files reviewed, all discussions resolved (waiting on @orizi)
commit-id:8f9766c2
orizi
force-pushed
the
pr/orizi/num-updates/8f9766c2
branch
from
4e97ed2 to
3de99ea
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
commit-id:8f9766c2
Stack:
PartialOrd::{gt,le,ge}. #6195 ⬅WideSquaretrait. #6194This change is