Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

LS: Stop spamming about tracing spans in logs #6515

Merged
merged 1 commit into from
Oct 25, 2024
Merged

LS: Stop spamming about tracing spans in logs #6515

merged 1 commit into from
Oct 25, 2024

Conversation

mkaput
Copy link
Collaborator

@mkaput mkaput commented Oct 24, 2024 •
edited
Loading

This was referenced Oct 24, 2024
Merged
Merged
Merged
Merged
@reviewable-StarkWare
Copy link

This change is Reviewable

@mkaput mkaput force-pushed the spr/main/9798ab5d branch from 705b500 to d0339b1 Compare October 24, 2024 15:38
@mkaput mkaput force-pushed the spr/main/8b5c4b9f branch from 2aae967 to 0fe2aa5 Compare October 24, 2024 15:38
piotmag769
piotmag769 approved these changes Oct 24, 2024
View reviewed changes
Copy link
Collaborator

@piotmag769 piotmag769 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

:lgtm:

Reviewed 1 of 1 files at r1, all commit messages.
Reviewable status: :shipit: complete! all files reviewed, all discussions resolved (waiting on @Arcticae, @Draggu, and @orizi)

@mkaput mkaput force-pushed the spr/main/9798ab5d branch from d0339b1 to fbb0efd Compare October 25, 2024 07:48
Draggu
Draggu approved these changes Oct 25, 2024
View reviewed changes
Copy link
Collaborator

@Draggu Draggu left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

:lgtm:

Reviewed 1 of 1 files at r1, all commit messages.
Reviewable status: :shipit: complete! all files reviewed, all discussions resolved (waiting on @Arcticae and @orizi)

Arcticae
Arcticae reviewed Oct 25, 2024
View reviewed changes
Copy link
Collaborator

@Arcticae Arcticae left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

:lgtm:

Reviewable status: :shipit: complete! all files reviewed, all discussions resolved (waiting on @orizi)

@mkaput mkaput changed the base branch from spr/main/8b5c4b9f to main October 25, 2024 10:59
@mkaput mkaput force-pushed the spr/main/9798ab5d branch from fbb0efd to 72a79f7 Compare October 25, 2024 10:59
@mkaput mkaput enabled auto-merge October 25, 2024 10:59
@mkaput mkaput added this pull request to the merge queue Oct 25, 2024
Merged via the queue into main with commit b997c2a Oct 25, 2024
87 checks passed
@mkaput mkaput deleted the spr/main/9798ab5d branch October 25, 2024 12:51
integraledelebesgue pushed a commit that referenced this pull request Oct 25, 2024
@mkaput @integraledelebesgue
LS: Stop spamming about tracing spans in logs (#6515)
f55254f
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@Arcticae Arcticae Arcticae left review comments

@Draggu Draggu Draggu approved these changes

@piotmag769 piotmag769 piotmag769 approved these changes

@orizi orizi Awaiting requested review from orizi

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
5 participants
@mkaput @reviewable-StarkWare @Arcticae @piotmag769 @Draggu