-
Notifications
You must be signed in to change notification settings - Fork 566
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
LS: Explicitly ignore Cancel
& SetTrace
without polluting logs
#6518
Conversation
99ad251
to
0278974
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Reviewed 2 of 2 files at r1, all commit messages.
Reviewable status: complete! all files reviewed, all discussions resolved (waiting on @Arcticae, @Draggu, and @orizi)
0278974
to
c39c30d
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Reviewed 2 of 2 files at r1, all commit messages.
Reviewable status: all files reviewed, 3 unresolved discussions (waiting on @Arcticae, @mkaput, and @orizi)
crates/cairo-lang-language-server/src/server/routing/mod.rs
line 97 at r1 (raw file):
DidSaveTextDocument::METHOD => local_notification_task::<DidSaveTextDocument>(notification), // Ignore these notifications as they are meaningless for CairoLS.
Can we explain here that LS know when to cancel on its own, without being notified by the client? Additionally, we ignore tracing settings because increasing it will quickly lead to overwhelmingly large traces. This would be more useful than only stating that these are meaningless.
crates/cairo-lang-language-server/src/server/routing/mod.rs
line 99 at r1 (raw file):
method => { warn!("received notification {method} which does not have a handler");
Please keep these lines
crates/cairo-lang-language-server/src/server/routing/mod.rs
line 105 at r1 (raw file):
.unwrap_or_else(|error| { error!("encountered error when routing notification: {error}");
Same here
c39c30d
to
3b7f659
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Reviewable status: 1 of 2 files reviewed, all discussions resolved (waiting on @Arcticae, @Draggu, @orizi, and @piotmag769)
crates/cairo-lang-language-server/src/server/routing/mod.rs
line 97 at r1 (raw file):
Previously, Draggu (Piotr Figiela) wrote…
Can we explain here that LS know when to cancel on its own, without being notified by the client? Additionally, we ignore tracing settings because increasing it will quickly lead to overwhelmingly large traces. This would be more useful than only stating that these are meaningless.
Done
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Reviewable status: 1 of 2 files reviewed, all discussions resolved (waiting on @Arcticae, @orizi, and @piotmag769)
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Reviewable status: 1 of 2 files reviewed, all discussions resolved (waiting on @Draggu, @orizi, and @piotmag769)
7a7602f
to
5c71563
Compare
fc01490
to
515c680
Compare
commit-id:09ef1ee1
515c680
to
d2826dc
Compare
No description provided.