Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Extracted entry-code creation into a basic configuration. #6640

Merged
merged 2 commits into from
Nov 17, 2024
Merged

Extracted entry-code creation into a basic configuration. #6640

merged 2 commits into from
Nov 17, 2024

Conversation

orizi
Copy link
Collaborator

@orizi orizi commented Nov 12, 2024 •
edited
Loading

This was referenced Nov 12, 2024
Closed
Merged
Merged
Merged
@reviewable-StarkWare
Copy link

This change is Reviewable

@orizi orizi changed the base branch from spr/main/b960baf9 to main November 12, 2024 14:26
@orizi orizi changed the base branch from main to spr/main/c7159ee0 November 12, 2024 14:26
@orizi orizi force-pushed the spr/main/a4fe6610 branch from 5bbc6a7 to 35bbaa5 Compare November 12, 2024 14:26
@orizi orizi changed the base branch from spr/main/c7159ee0 to main November 13, 2024 10:31
@orizi orizi force-pushed the spr/main/a4fe6610 branch from 35bbaa5 to ebd2759 Compare November 13, 2024 10:31
@orizi orizi changed the base branch from main to spr/main/c7159ee0 November 13, 2024 10:32
@orizi orizi mentioned this pull request Nov 13, 2024
Closed
gilbens-starkware
gilbens-starkware approved these changes Nov 17, 2024
View reviewed changes
Copy link
Contributor

@gilbens-starkware gilbens-starkware left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

:lgtm:

Reviewed 3 of 3 files at r1, all commit messages.
Reviewable status: :shipit: complete! all files reviewed, all discussions resolved (waiting on @orizi)

@orizi orizi force-pushed the spr/main/c7159ee0 branch from 74035ce to 0336b70 Compare November 17, 2024 08:03
@orizi orizi force-pushed the spr/main/a4fe6610 branch from ebd2759 to 4d219df Compare November 17, 2024 08:03
@orizi orizi changed the base branch from spr/main/c7159ee0 to main November 17, 2024 08:03
@orizi orizi enabled auto-merge November 17, 2024 08:03
@orizi orizi added this pull request to the merge queue Nov 17, 2024
Merged via the queue into main with commit e9f3b1b Nov 17, 2024
140 checks passed
@orizi orizi deleted the spr/main/a4fe6610 branch November 18, 2024 08:19
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@gilbens-starkware gilbens-starkware gilbens-starkware approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@orizi @reviewable-StarkWare @gilbens-starkware