Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Made the plugin compilation be based on the wrapper functions. #6642

Merged
merged 1 commit into from
Nov 17, 2024

Conversation

orizi
Copy link
Collaborator

@orizi orizi commented Nov 12, 2024

Stack:

⚠️ Part of a stack created by spr. Do not merge manually using the UI - doing so may have unexpected results.

@reviewable-StarkWare
Copy link

This change is Reviewable

@orizi orizi changed the base branch from spr/main/c7159ee0 to main November 12, 2024 14:26
@orizi orizi changed the base branch from main to spr/main/a4fe6610 November 12, 2024 14:26
@orizi orizi force-pushed the spr/main/4213f446 branch from 34a6fda to c0e38c8 Compare November 12, 2024 14:26
@orizi orizi changed the base branch from spr/main/a4fe6610 to main November 13, 2024 10:31
@orizi orizi force-pushed the spr/main/4213f446 branch from c0e38c8 to 5ecd1e1 Compare November 13, 2024 10:31
@orizi orizi changed the base branch from main to spr/main/a4fe6610 November 13, 2024 10:32
@orizi orizi force-pushed the spr/main/4213f446 branch from 5ecd1e1 to 8878fa6 Compare November 17, 2024 08:03
@orizi orizi force-pushed the spr/main/a4fe6610 branch from ebd2759 to 4d219df Compare November 17, 2024 08:03
@orizi orizi changed the base branch from spr/main/a4fe6610 to main November 17, 2024 08:56
@orizi orizi force-pushed the spr/main/4213f446 branch from 8878fa6 to 08c3011 Compare November 17, 2024 08:56
Copy link
Contributor

@gilbens-starkware gilbens-starkware left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Reviewed all commit messages.
Reviewable status: 0 of 5 files reviewed, 1 unresolved discussion (waiting on @orizi)


crates/cairo-lang-runnable/src/compile.rs line 79 at r1 (raw file):

/// Returns the path to the function that the runnable is wrapping.
///
/// If the runnable is not wrapping a function, returns the full path of the runnable.

It is possible only if writing a runnable manually, right?

Code quote:

/// If the runnable is not wrapping a function, returns the full path of the runnable.

Copy link
Collaborator Author

@orizi orizi left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Reviewable status: 0 of 5 files reviewed, 1 unresolved discussion (waiting on @gilbens-starkware)


crates/cairo-lang-runnable/src/compile.rs line 79 at r1 (raw file):

Previously, gilbens-starkware (Gil Ben-Shachar) wrote…

It is possible only if writing a runnable manually, right?

yes.

Copy link
Contributor

@gilbens-starkware gilbens-starkware left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

:lgtm:

Reviewed 5 of 5 files at r1.
Reviewable status: :shipit: complete! all files reviewed, all discussions resolved (waiting on @orizi)

@orizi orizi added this pull request to the merge queue Nov 17, 2024
Merged via the queue into main with commit 7817768 Nov 17, 2024
94 checks passed
@orizi orizi deleted the spr/main/4213f446 branch November 18, 2024 08:19
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants