Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add arithmetic op counts to InfoEvaluator #832

Open
wants to merge 1 commit into
base: dev
Choose a base branch
from

Conversation

andrewmilson
Copy link
Contributor

@andrewmilson andrewmilson commented Sep 16, 2024

Couldn't see a way to add the counting types without removing Copy from a few places.
Some constraint code is a bit more ugly now :(


This change is Reviewable

@codecov-commenter
Copy link

codecov-commenter commented Sep 16, 2024

Codecov Report

Attention: Patch coverage is 93.47826% with 12 lines in your changes missing coverage. Please review.

Project coverage is 91.93%. Comparing base (6e649fc) to head (a46c994).

Files with missing lines Patch % Lines
crates/prover/src/constraint_framework/info.rs 93.82% 9 Missing and 2 partials ⚠️
crates/prover/src/core/lookups/utils.rs 66.66% 0 Missing and 1 partial ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##              dev     #832      +/-   ##
==========================================
+ Coverage   91.91%   91.93%   +0.02%     
==========================================
  Files          90       90              
  Lines       12375    12548     +173     
  Branches    12375    12548     +173     
==========================================
+ Hits        11374    11536     +162     
- Misses        892      901       +9     
- Partials      109      111       +2     
Flag Coverage Δ
91.93% <93.47%> (+0.02%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@andrewmilson andrewmilson force-pushed the 09-15-Add_arithmetic_op_counts_to_InfoEvaluator branch 2 times, most recently from 4c79a3d to d79f369 Compare September 16, 2024 05:23
Base automatically changed from 09-11-Add_size_estimate_for_StarkProof to dev September 16, 2024 19:18
@andrewmilson andrewmilson force-pushed the 09-15-Add_arithmetic_op_counts_to_InfoEvaluator branch from d79f369 to 798f58a Compare September 24, 2024 05:20
@andrewmilson andrewmilson force-pushed the 09-15-Add_arithmetic_op_counts_to_InfoEvaluator branch from 798f58a to a46c994 Compare September 25, 2024 21:22
Copy link
Contributor

@Alon-Ti Alon-Ti left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Reviewed 2 of 15 files at r1, 14 of 14 files at r3, all commit messages.
Reviewable status: all files reviewed, 1 unresolved discussion (waiting on @andrewmilson and @shaharsamocha7)


crates/prover/src/examples/poseidon/mod.rs line 30 at r3 (raw file):

use crate::core::ColumnVec;

const N_LOG_INSTANCES_PER_ROW: usize = 0;

It still works with 3 though, right?

@andrewmilson andrewmilson force-pushed the 09-15-Add_arithmetic_op_counts_to_InfoEvaluator branch from a46c994 to 19e4fac Compare November 19, 2024 13:58
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants