Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Return opening positions and query positions per column size in FRI #856

Draft
wants to merge 1 commit into
base: 09-23-Make_CommitmentSchemeProver_prove_values_take_ownership
Choose a base branch
from

Conversation

andrewmilson
Copy link
Contributor

@andrewmilson andrewmilson commented Sep 25, 2024

This change is Reviewable

Copy link
Contributor Author

andrewmilson commented Sep 25, 2024

Warning

This pull request is not mergeable via GitHub because a downstack PR is open. Once all requirements are satisfied, merge this PR as a stack on Graphite.
Learn more

This stack of pull requests is managed by Graphite. Learn more about stacking.

@codecov-commenter
Copy link

Codecov Report

Attention: Patch coverage is 94.82759% with 3 lines in your changes missing coverage. Please review.

Project coverage is 91.96%. Comparing base (64b9479) to head (39cb578).

Files with missing lines Patch % Lines
crates/prover/src/core/queries.rs 0.00% 0 Missing and 2 partials ⚠️
crates/prover/src/core/fri.rs 97.61% 0 Missing and 1 partial ⚠️
Additional details and impacted files
@@                                      Coverage Diff                                       @@
##           09-23-Make_CommitmentSchemeProver_prove_values_take_ownership     #856   +/-   ##
==============================================================================================
  Coverage                                                          91.95%   91.96%           
==============================================================================================
  Files                                                                 90       90           
  Lines                                                              12544    12571   +27     
  Branches                                                           12544    12571   +27     
==============================================================================================
+ Hits                                                               11535    11561   +26     
  Misses                                                               898      898           
- Partials                                                             111      112    +1     
Flag Coverage Δ
91.96% <94.82%> (+<0.01%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@andrewmilson andrewmilson force-pushed the 09-23-Make_CommitmentSchemeProver_prove_values_take_ownership branch from 64b9479 to 16f372f Compare November 19, 2024 13:58
@andrewmilson andrewmilson force-pushed the 09-23-Return_opening_positions_and_query_positions_per_column_size_in_FRI branch from 39cb578 to 2811e40 Compare November 19, 2024 13:58
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants