Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Rc2.3 calib #836

Merged
merged 30 commits into from
Feb 14, 2025
Merged

Rc2.3 calib #836

merged 30 commits into from
Feb 14, 2025

Conversation

daniel-klein
Copy link
Contributor

Description

Adds a flag continue_db to calibration. Also allows the user to save calibration results using save_csv.

Also addresses #826

Checklist

  • Code commented & docstrings added
  • New tests were needed and have been added
  • A new version number was needed & changelog has been updated
  • A new PyPI version needs to be released

… not want to take .values. Beginning of addressing #846.
…ing with both 'x' and 'n' wherein there's only one data point.
* Separated combining replicates from bootstrapping. The default combine_reps is now None, which bypasses combining replicates.
* Now taking the mean across replicates instead of the sum. This change is important if using the `include_fn` and some replicates are rejected, resulting in a varying number of replicates across input parameter sets. The mean is the right operation here, not the sum.
* Fix a bug that was causing check_fit to do 4 replicates even when the user did not ask for replicates.
* Re-enabling calibration tests.
…lace +1) method to avoid bias. A user could manually add 1 to x and n if they want the prior (1,1) instead.
@cliffckerr cliffckerr merged commit 3f31617 into rc2.3 Feb 14, 2025
0 of 3 checks passed
@cliffckerr cliffckerr deleted the rc2.3_calib branch February 14, 2025 04:41
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants