-
Notifications
You must be signed in to change notification settings - Fork 52
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Set time_from_start to feedback of joint trajectory action #1049
Closed
pazeshun
wants to merge
3
commits into
start-jsk:master
from
pazeshun:add-time-from-start-to-feedback
Closed
Set time_from_start to feedback of joint trajectory action #1049
pazeshun
wants to merge
3
commits into
start-jsk:master
from
pazeshun:add-time-from-start-to-feedback
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This behaviour is correct? If not, I want to fix this behaviour in this PR. |
k-okada
approved these changes
Jul 24, 2018
@Affonso-Gui Please use this. |
@pazeshun Thanks. Looking forward to being merged. |
@k-okada Can we merge this? It has been approved and passes the checks. |
This was referenced Oct 26, 2019
Moved to #1073 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
For jsk-ros-pkg/jsk_pr2eus#233 (comment)
Complement #966
Note:
Feedback from
HrpsysSeqStateROSBridge
(fullbody_controller) always comes after first joint trajectory, so its time_from_start increases until next trajectory comes.On the other hand, feedback from
HrpsysJointTrajectoryBridge
(rarm_controller etc.) stops when each trajectory is completely executed.