-
-
Notifications
You must be signed in to change notification settings - Fork 803
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add new v2.5 UI #357
Add new v2.5 UI #357
Conversation
Looks awsome. It may not be "sexy" but i think it's more user friendly especially the mobile version. A few things i encountered while "playing" with it.
|
@bnkai Thanks for the feedback. I've rewritten the list filter hooks so it behaves the same as v2, and added a hamburger menu in mobile mode. Also fixed the other issues you mentioned. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Just a couple of minor changes.
Other things:
- I'd prefer that the Scrape with menu button drops down a sub-menu of scrapers, rather than a horizontal list as does currently.
- Needs the recent UI updates from Make performer image position top #358, Update stats page #366
- When creating a filter, if you don't explicitly set the value field, then it ends up with 0 or blank. Same with Is Missing and its field.
- Scenes list view seems pretty broken
- You may have mentioned this already - scene edit page is a bit screwy on narrow screens
- There's a bunch of style changes that I'd like just to make it as close to the old version where possible, but this can wait to a later iteration.
I think if we can get the bugs ironed out, we should get this merged and sort out the move from v2 in a separate PR, once the two versions are fully aligned.
* Refactored LocalForage * Refactored SceneFilenameParser
All the issues you pointed out should be resolved now. |
Looks great.
|
New UI based on a refactor of the existing v2 UI.
The user facing changes are:
<FormattedMessage />
and runyarn extract
to populate the message files insrc/locale
. To support this all text should be wrapped in<FormattedMessage>
orformatMessage
, all dates wraped inn<FormattedDate>
, and all numbers in<FormattedNumber>
. For more info see the react-intl documentation. New languages can be added by editing theyarn extract
command and the dropdown in the config menu, and then editing the resulting [language-code].json in the locale folder.There have also been a large amount of behind the scenes changes:
useEffect
hooks which are prone to create confusing and brittle code.any
in the linter, and rewrote or exempted all uses of it.yarn format
.src/component|hooks|utils/Name/File
. This makes it easier to see where imports and coming from, and means they won't break when copy-pasted, or the file is moved.Some things to note:
ui/v2.5
folder the only change is adding the language config setting to graphql. This shouldn't affect the v2 branch at all, and they can in fact be run side by side without problem as long as v2.5 is manually started in dev mode. To switch release version the packr2 box has to be changed from v2 to v2.5, and stash rebuilt.<Icon>
component and specify an icon from fontawesome with the icon prop.