Remove { collection } route binding #5774
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ryanmitchell
changed the title
|
I appreciate this PR and think it's a good change to have, but I think it might be a potential breaking change for addons that may be relying on these bindings in the control panel. Could we instead just provide the bindings to control panel routes? Like we do for the API: cms/src/Providers/RouteServiceProvider.php Lines 89 to 91 in 38f1116 Have one of these: if (! $this->isCpRoute($route)) {
return $handle;
} |
edalzell
reviewed
Apr 6, 2022
| if (! $collection) { | ||
| throw new NotFoundHttpException("Collection [$collectionHandle] not found."); | ||
| } | ||
|
|
There was a problem hiding this comment.
throw_unless($collection = Collection::findByHandle($collection))?
edalzell
reviewed
Apr 6, 2022
| if (! $collection) { | ||
| throw new NotFoundHttpException("Collection [$collectionHandle] not found."); | ||
| } | ||
|
|
|
@jasonvarga well that would have been a lot less work 🤣 new PR incoming |
|
Sorry 😬 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I'm having issues with the
{ collection }route binding when using Statamic alongside another package.So as suggested here I've removed the collection binding from all routes that use it.
I'm happy to do the leg work on any changes you want to this - so just direct me.