Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Ensure route bindings only apply to Statamic routes #5775

Merged
merged 4 commits into from
May 20, 2022
Merged

Ensure route bindings only apply to Statamic routes #5775

merged 4 commits into from
May 20, 2022

Conversation

ryanmitchell
Copy link
Contributor

@ryanmitchell ryanmitchell commented Apr 6, 2022 •
edited
Loading

A better approach (replacing #5774)

Check if we are in a Statamic CP or API route before applying bindings.

Fixes: #4108

@ryanmitchell ryanmitchell mentioned this pull request Apr 7, 2022
Closed
@jasonvarga
Copy link
Member

Thanks Ryan.

@jasonvarga jasonvarga merged commit 662bc32 into statamic:3.3 May 20, 2022
@ryanmitchell ryanmitchell deleted the chore/remove-route-bindings-outside-statamic branch May 20, 2022 06:39
@ryanmitchell ryanmitchell mentioned this pull request Jun 3, 2022
Closed
@jasonvarga jasonvarga mentioned this pull request Jun 7, 2022
Merged
@jasonvarga jasonvarga mentioned this pull request Oct 3, 2023
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Route Model Binding Exception
2 participants
@ryanmitchell @jasonvarga