Add internal/project #433
Closed
Add internal/project #433
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
adambabik
force-pushed
the
adamb/implement-project-internal
branch
from
1864efa to
c595215
Compare
|
Great @adambabik! Should we review it now or once it's integrated? |
|
@sourishkrout let's do it now so that the PR is not massive. I will create a projects gRPC service based on it first, and when it's accepted, I will integrate "internal/project" into other parts of the program. |
2 tasks
It implements similar functionality to pkg/projects, but hides implementation details and is intended to be a building block for a gRPC service.
adambabik
force-pushed
the
adamb/implement-project-internal
branch
from
c595215 to
2ec8fd9
Compare
|
@sourishkrout After giving it a bit more thought, I think it might be hard to review from the functional point of view. Let's do it when the gRPC service is implemented. |
Aye aye, sir! |
|
Replaced with #438 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR adds a refactored implementation of
pkg/projectininternal/project. For now, it's unused. Further adjustments will be added, when the usage ofinternal/projectis incorporated in the rest of the program.