-
Notifications
You must be signed in to change notification settings - Fork 40
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Implement Project service #438
Conversation
Got it working locally: https://app.runme.dev/cell/clphggfii0013s601ou0tpnrk |
@@ -0,0 +1 @@ | |||
x��Qj1D��S述Ȋ�� ��7�-;Y����ܿ.������m߷��i�R�%�#���ѳ�D�nEĭj�d�T���^�8��gr.̩e�Ps���L>eҚ�y�{��÷��Y�_�j9�۳�>�c�m��m�sd�@�hf;EGy���#���r��|k��_YxL� |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@adambabik what's all this?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I wanted to have a real git repository to do integration tests. As it's possible to embed one git repository in another, except for git submodule but then the submodule must be a standalone repo, I just changed .git
to .git.bkp
and added it directly. Before running the tests, I do cp -r .git.bkp .git
.
There are a few nicer alternatives:
- Have it as an actual standalone repo and use submodules.
- Compress and commit a single tar file.
- Create a repo from scratch as a test setup step in the temp dir.
I think the last one should be doable purely using go-git. I will try to do that.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
All good. If it works, it works. Mainly wanted to make sure it's intentional.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Ok, I will fix it in another PR.
Added examples here #442, please consider merging @adambabik. |
One thing that I believe would be good to change is to reverse some params like |
7be5dc5
to
be8f461
Compare
When you have a moment, please merge/rebase the latest |
It implements similar functionality to pkg/projects, but hides implementation details and is intended to be a building block for a gRPC service.
94e177d
to
302d72f
Compare
Based on starting with a VS Code Task-based integration here are some notes:
|
@sourishkrout I addressed (2) in 5a4dc61. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
👍 LGTM
This PR implements a new service to load tasks from a project.
Usage
After starting the server using
runme server
, you will be able to list the newProjectService
:There is only one method called
Load
and it streams a list of events while loading a file- or dir-based project.For a file-based project:
For a dir-based project: