fix: error checking (#345)

* fix: error checking

Error received may be empty object which is truthy in JavaScript.  Check for falsy values OR empty objects when deciding if an error is truthy.

* fix: Wrong error check

src/components/feedback/Fetching.tsx

@@ -1,6 +1,6 @@
 import { PropsWithChildren, ReactNode, useState } from "react"
 import LinearProgress from "@mui/material/LinearProgress"
-import { getErrorMessage } from "utils/error"
+import { getErrorMessage, isError } from "utils/error"
 import useTimeout from "utils/hooks/useTimeout"
 import { Card } from "../layout"
 import Wrong from "./Wrong"
@@ -37,7 +37,7 @@ export const WithFetching = (props: WithFetchingProps) => {
             sx={{ position: "absolute" /* to overwrite */ }}
           />
         ) : undefined,
-        error ? <Wrong>{getErrorMessage(error)}</Wrong> : undefined
+        isError(error) ? <Wrong>{getErrorMessage(error)}</Wrong> : undefined
       )}
     </>
   )

src/utils/error.ts

@@ -1,12 +1,22 @@
 import axios, { AxiosError } from "axios"
 
 export const getErrorMessage = (
-  error?: Error | AxiosError | unknown
+  error?: Error | AxiosError | object | unknown
 ): string | undefined => {
-  if (!error) return
+  if (!isError(error)) return
 
   if (axios.isAxiosError(error))
     return (error as AxiosError<any>).response?.data?.message ?? error.message
 
   if (error instanceof Error) return error.message
 }
+
+export const isError = (
+  error?: Error | AxiosError | object | unknown
+): boolean => {
+  if (!error || JSON.stringify(error) === "{}") {
+    return false
+  } else {
+    return true
+  }
+}