fix: error checking #345
Merged
fix: error checking #345
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Error received may be empty object which is truthy in JavaScript. Check for falsy values OR empty objects when deciding if an error is truthy.
Deploying with
|
| Latest commit: |
a85bc8e
|
| Status: | ✅ Deploy successful! |
| Preview URL: | https://09159ab0.station-1a1.pages.dev |
| Branch Preview URL: | https://fix-error-checking.station-1a1.pages.dev |
terran6
added a commit
that referenced
this pull request
May 23, 2023
* fix: always show native assets regardless of denoms (#348) * St 353 display chain selection on inactive chain click in OtherChainButtons (#329) * WIP: chains display prefs open * feat: open preferences on click * cleanup * cleanup * feat: swap terra.kitchen/utils for @terra-money/terra-utils (#321) * feat: guard against empty networks, chaindID, or lcd (#327) * feat: kado integration and updated wallet buttons (#320) * feat: kado integration and updated wallet buttons * Fix passing/not passing * fix prettier * fix: always show native assets regardless of denoms * Update chain.ts * fix: hide low balance * fix: remove log * fix: code readability Changing code to follow logic for improved readability. * fix: exclude cw20 tokens --------- Co-authored-by: Mike <17463738+mwmerz@users.noreply.github.com> Co-authored-by: Alessandro Candeago <54709706+alecande11@users.noreply.github.com> Co-authored-by: Manuel Alessandro Collazo <collazo.manuel6@gmail.com> * fix: error checking (#345) * fix: error checking Error received may be empty object which is truthy in JavaScript. Check for falsy values OR empty objects when deciding if an error is truthy. * fix: Wrong error check * fix: broken history links (#380) * St 355 moon theme (#379) * changes blossom theme colors and changed some font styles mainly font-smoothing and font weight adjusted to reflect antialiased smoothing * Added navigation background and aside blurs ST-309 * changed blossom mp4 location * fixed aside blur on smaller heights * changed where the aside blurs are placed and added better management for mobile and small heights * fixed other changes I wanted in * changes colors * completed moon theme changes. Also implimented two toned cards the are on all themes along with some other small UI changes ST-355 * fixing mobile issues ST-355 * added theme stake amounts back in * changed background blob color to lighter, changed preview svg and removed staking minimums to themes * removed image I forgot to delete * St 355 pt4 (#382) * updated moon preview * changed preview colors * removed system default theme and makes it dark mode ST-433 (#383) * fix: password validation (#385) * fix: password validation * fix: onFocus password confirmation --------- Co-authored-by: plubber <51789398+ericHgorski@users.noreply.github.com> Co-authored-by: Mike <17463738+mwmerz@users.noreply.github.com> Co-authored-by: Alessandro Candeago <54709706+alecande11@users.noreply.github.com> Co-authored-by: Joshua Brigati <brigati.joshua@gmail.com>
mwmerz
added a commit
that referenced
this pull request
May 29, 2023
* fix: always show native assets regardless of denoms (#348) * St 353 display chain selection on inactive chain click in OtherChainButtons (#329) * WIP: chains display prefs open * feat: open preferences on click * cleanup * cleanup * feat: swap terra.kitchen/utils for @terra-money/terra-utils (#321) * feat: guard against empty networks, chaindID, or lcd (#327) * feat: kado integration and updated wallet buttons (#320) * feat: kado integration and updated wallet buttons * Fix passing/not passing * fix prettier * fix: always show native assets regardless of denoms * Update chain.ts * fix: hide low balance * fix: remove log * fix: code readability Changing code to follow logic for improved readability. * fix: exclude cw20 tokens --------- Co-authored-by: Mike <17463738+mwmerz@users.noreply.github.com> Co-authored-by: Alessandro Candeago <54709706+alecande11@users.noreply.github.com> Co-authored-by: Manuel Alessandro Collazo <collazo.manuel6@gmail.com> * fix: error checking (#345) * fix: error checking Error received may be empty object which is truthy in JavaScript. Check for falsy values OR empty objects when deciding if an error is truthy. * fix: Wrong error check * fix: broken history links (#380) * St 355 moon theme (#379) * changes blossom theme colors and changed some font styles mainly font-smoothing and font weight adjusted to reflect antialiased smoothing * Added navigation background and aside blurs ST-309 * changed blossom mp4 location * fixed aside blur on smaller heights * changed where the aside blurs are placed and added better management for mobile and small heights * fixed other changes I wanted in * changes colors * completed moon theme changes. Also implimented two toned cards the are on all themes along with some other small UI changes ST-355 * fixing mobile issues ST-355 * added theme stake amounts back in * changed background blob color to lighter, changed preview svg and removed staking minimums to themes * removed image I forgot to delete * St 355 pt4 (#382) * updated moon preview * changed preview colors * removed system default theme and makes it dark mode ST-433 (#383) * fix: password validation (#385) * fix: password validation * fix: onFocus password confirmation --------- Co-authored-by: plubber <51789398+ericHgorski@users.noreply.github.com> Co-authored-by: Mike <17463738+mwmerz@users.noreply.github.com> Co-authored-by: Alessandro Candeago <54709706+alecande11@users.noreply.github.com> Co-authored-by: Joshua Brigati <brigati.joshua@gmail.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Error received may be empty object which is truthy in JavaScript. Check for falsy values OR empty objects when deciding if an error is truthy.