fix: always show native assets regardless of denoms #348

ericHgorski · 2023-04-19T18:23:59Z

No description provided.

…uttons (#329) * WIP: chains display prefs open * feat: open preferences on click * cleanup * cleanup

* feat: kado integration and updated wallet buttons

ericHgorski · 2023-04-19T18:24:13Z

If this looks good, Ill make same change on extension

ericHgorski · 2023-04-19T18:24:28Z

src/utils/chain.ts

@@ -55,3 +55,5 @@ export const useSortedDisplayChains = () => {

 export const useTerraChainName = () =>
  useNetworkName() === "mainnet" ? "phoenix-1" : "pisco-1"
+
+export const isNativeToken = (denom: string) => !denom.startsWith("ibc/")


Is this robust @alecande11 ?

I think now that we have the token factory module, we should also check if the denom starts with factory/

cloudflare-workers-and-pages · 2023-04-19T18:29:13Z

Deploying with Cloudflare Pages

Latest commit:	`3811e90`
Status:	✅ Deploy successful!
Preview URL:	https://6618aeb7.station-1a1.pages.dev
Branch Preview URL:	https://st-387-show-native-assets.station-1a1.pages.dev

View logs

alecande11 · 2023-04-24T15:09:48Z

src/utils/chain.ts

@@ -55,3 +55,5 @@ export const useSortedDisplayChains = () => {

 export const useTerraChainName = () =>
  useNetworkName() === "mainnet" ? "phoenix-1" : "pisco-1"
+
+export const isNativeToken = (denom: string) => !denom.startsWith("ibc/")


I think now that we have the token factory module, we should also check if the denom starts with factory/

Changing code to follow logic for improved readability.

* fix: always show native assets regardless of denoms (#348) * St 353 display chain selection on inactive chain click in OtherChainButtons (#329) * WIP: chains display prefs open * feat: open preferences on click * cleanup * cleanup * feat: swap terra.kitchen/utils for @terra-money/terra-utils (#321) * feat: guard against empty networks, chaindID, or lcd (#327) * feat: kado integration and updated wallet buttons (#320) * feat: kado integration and updated wallet buttons * Fix passing/not passing * fix prettier * fix: always show native assets regardless of denoms * Update chain.ts * fix: hide low balance * fix: remove log * fix: code readability Changing code to follow logic for improved readability. * fix: exclude cw20 tokens --------- Co-authored-by: Mike <17463738+mwmerz@users.noreply.github.com> Co-authored-by: Alessandro Candeago <54709706+alecande11@users.noreply.github.com> Co-authored-by: Manuel Alessandro Collazo <collazo.manuel6@gmail.com> * fix: error checking (#345) * fix: error checking Error received may be empty object which is truthy in JavaScript. Check for falsy values OR empty objects when deciding if an error is truthy. * fix: Wrong error check * fix: broken history links (#380) * St 355 moon theme (#379) * changes blossom theme colors and changed some font styles mainly font-smoothing and font weight adjusted to reflect antialiased smoothing * Added navigation background and aside blurs ST-309 * changed blossom mp4 location * fixed aside blur on smaller heights * changed where the aside blurs are placed and added better management for mobile and small heights * fixed other changes I wanted in * changes colors * completed moon theme changes. Also implimented two toned cards the are on all themes along with some other small UI changes ST-355 * fixing mobile issues ST-355 * added theme stake amounts back in * changed background blob color to lighter, changed preview svg and removed staking minimums to themes * removed image I forgot to delete * St 355 pt4 (#382) * updated moon preview * changed preview colors * removed system default theme and makes it dark mode ST-433 (#383) * fix: password validation (#385) * fix: password validation * fix: onFocus password confirmation --------- Co-authored-by: plubber <51789398+ericHgorski@users.noreply.github.com> Co-authored-by: Mike <17463738+mwmerz@users.noreply.github.com> Co-authored-by: Alessandro Candeago <54709706+alecande11@users.noreply.github.com> Co-authored-by: Joshua Brigati <brigati.joshua@gmail.com>

* St 353 display chain selection on inactive chain click in OtherChainButtons (#329) * WIP: chains display prefs open * feat: open preferences on click * cleanup * cleanup * feat: swap terra.kitchen/utils for @terra-money/terra-utils (#321) * feat: guard against empty networks, chaindID, or lcd (#327) * feat: kado integration and updated wallet buttons (#320) * feat: kado integration and updated wallet buttons * Fix passing/not passing * fix prettier * fix: always show native assets regardless of denoms * Update chain.ts * fix: hide low balance * fix: remove log * fix: code readability Changing code to follow logic for improved readability. * fix: exclude cw20 tokens --------- Co-authored-by: Mike <17463738+mwmerz@users.noreply.github.com> Co-authored-by: Alessandro Candeago <54709706+alecande11@users.noreply.github.com> Co-authored-by: Manuel Alessandro Collazo <collazo.manuel6@gmail.com>

* fix: always show native assets regardless of denoms (#348) * St 353 display chain selection on inactive chain click in OtherChainButtons (#329) * WIP: chains display prefs open * feat: open preferences on click * cleanup * cleanup * feat: swap terra.kitchen/utils for @terra-money/terra-utils (#321) * feat: guard against empty networks, chaindID, or lcd (#327) * feat: kado integration and updated wallet buttons (#320) * feat: kado integration and updated wallet buttons * Fix passing/not passing * fix prettier * fix: always show native assets regardless of denoms * Update chain.ts * fix: hide low balance * fix: remove log * fix: code readability Changing code to follow logic for improved readability. * fix: exclude cw20 tokens --------- Co-authored-by: Mike <17463738+mwmerz@users.noreply.github.com> Co-authored-by: Alessandro Candeago <54709706+alecande11@users.noreply.github.com> Co-authored-by: Manuel Alessandro Collazo <collazo.manuel6@gmail.com> * fix: error checking (#345) * fix: error checking Error received may be empty object which is truthy in JavaScript. Check for falsy values OR empty objects when deciding if an error is truthy. * fix: Wrong error check * fix: broken history links (#380) * St 355 moon theme (#379) * changes blossom theme colors and changed some font styles mainly font-smoothing and font weight adjusted to reflect antialiased smoothing * Added navigation background and aside blurs ST-309 * changed blossom mp4 location * fixed aside blur on smaller heights * changed where the aside blurs are placed and added better management for mobile and small heights * fixed other changes I wanted in * changes colors * completed moon theme changes. Also implimented two toned cards the are on all themes along with some other small UI changes ST-355 * fixing mobile issues ST-355 * added theme stake amounts back in * changed background blob color to lighter, changed preview svg and removed staking minimums to themes * removed image I forgot to delete * St 355 pt4 (#382) * updated moon preview * changed preview colors * removed system default theme and makes it dark mode ST-433 (#383) * fix: password validation (#385) * fix: password validation * fix: onFocus password confirmation --------- Co-authored-by: plubber <51789398+ericHgorski@users.noreply.github.com> Co-authored-by: Mike <17463738+mwmerz@users.noreply.github.com> Co-authored-by: Alessandro Candeago <54709706+alecande11@users.noreply.github.com> Co-authored-by: Joshua Brigati <brigati.joshua@gmail.com>

* St 353 display chain selection on inactive chain click in OtherChainButtons (#329) * WIP: chains display prefs open * feat: open preferences on click * cleanup * cleanup * feat: swap terra.kitchen/utils for @terra-money/terra-utils (#321) * feat: guard against empty networks, chaindID, or lcd (#327) * feat: kado integration and updated wallet buttons (#320) * feat: kado integration and updated wallet buttons * Fix passing/not passing * fix prettier * fix: always show native assets regardless of denoms * Update chain.ts * fix: hide low balance * fix: remove log * fix: code readability Changing code to follow logic for improved readability. * fix: exclude cw20 tokens --------- Co-authored-by: Mike <17463738+mwmerz@users.noreply.github.com> Co-authored-by: Alessandro Candeago <54709706+alecande11@users.noreply.github.com> Co-authored-by: Manuel Alessandro Collazo <collazo.manuel6@gmail.com>

ericHgorski and others added 9 commits April 3, 2023 16:59

St 353 display chain selection on inactive chain click in OtherChainB…

f229956

…uttons (#329) * WIP: chains display prefs open * feat: open preferences on click * cleanup * cleanup

feat: swap terra.kitchen/utils for @terra-money/terra-utils (#321)

3d6d359

feat: guard against empty networks, chaindID, or lcd (#327)

c699eef

feat: kado integration and updated wallet buttons (#320)

8c99b55

* feat: kado integration and updated wallet buttons

Fix passing/not passing

7408050

fix prettier

e22a633

Merge branch 'main' into staging

a445355

Merge branch 'staging' of github.com:terra-money/station into staging

c2c9ba1

fix: always show native assets regardless of denoms

c298a7e

ericHgorski requested a review from alecande11 April 19, 2023 18:23

ericHgorski commented Apr 19, 2023

View reviewed changes

alecande11 suggested changes Apr 24, 2023

View reviewed changes

ericHgorski and others added 4 commits April 24, 2023 13:26

Update chain.ts

0cca83e

fix: hide low balance

bb78390

fix: remove log

d01adbc

fix: code readability

6c8d034

Changing code to follow logic for improved readability.

alecande11 approved these changes May 3, 2023

View reviewed changes

alecande11 force-pushed the staging branch from c7c84b8 to 4d7193b Compare May 4, 2023 14:48

fix: exclude cw20 tokens

8da043d

mwmerz approved these changes May 11, 2023

View reviewed changes

Merge branch 'staging' into ST-387-show-native-assets

3811e90

mwmerz approved these changes May 11, 2023

View reviewed changes

terran6 merged commit b12c830 into staging May 11, 2023

terran6 deleted the ST-387-show-native-assets branch May 11, 2023 15:28

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

fix: always show native assets regardless of denoms #348

fix: always show native assets regardless of denoms #348

ericHgorski commented Apr 19, 2023

ericHgorski commented Apr 19, 2023

ericHgorski Apr 19, 2023

alecande11 Apr 24, 2023

cloudflare-workers-and-pages bot commented Apr 19, 2023 •

edited

Loading

alecande11 Apr 24, 2023

fix: always show native assets regardless of denoms #348

fix: always show native assets regardless of denoms #348

Conversation

ericHgorski commented Apr 19, 2023

ericHgorski commented Apr 19, 2023

ericHgorski Apr 19, 2023

Choose a reason for hiding this comment

alecande11 Apr 24, 2023

Choose a reason for hiding this comment

cloudflare-workers-and-pages bot commented Apr 19, 2023 • edited Loading

Deploying with Cloudflare Pages

alecande11 Apr 24, 2023

Choose a reason for hiding this comment

cloudflare-workers-and-pages bot commented Apr 19, 2023 •

edited

Loading