Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

ST-582: show disabled networks name and icon on the asset page #454

Merged
merged 1 commit into from
Jul 5, 2023

Conversation

alecande11
Copy link
Contributor

See linked jira issue for details.

Before:
Screenshot 2023-07-05 at 11 13 33

After:
Screenshot 2023-07-05 at 11 12 23

@alecande11 alecande11 requested a review from terran6 July 5, 2023 09:15
@cloudflare-workers-and-pages
Copy link

Deploying with  Cloudflare Pages  Cloudflare Pages

Latest commit: af03fba
Status: ✅  Deploy successful!
Preview URL: https://55d34a81.station-1a1.pages.dev
Branch Preview URL: https://st-582-show-disabled-network.station-1a1.pages.dev

View logs

@alecande11 alecande11 merged commit a2a21ca into staging Jul 5, 2023
@alecande11 alecande11 deleted the ST-582-show-disabled-network-name branch July 5, 2023 10:28

const networks = useNetwork()
const { devMode } = useDevMode()

const { icon, name } = networks[chain] || {}
const { icon, name } = allNetworks[chain] ?? { name: chain }
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@alecande11 just want to make sure, you want to replace the chain name of unknown chains with the chain name for the particular network on Terra?

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

No, with their chainID

mwmerz added a commit that referenced this pull request Jul 12, 2023
* fixed wallet popover overlapping on top of Send and Recieve title ST-475 (#436)
* fix: add scroll to chainlist container (#437)
* feat: filter out non-whitelisted tokens (#439)
* feat: disable send if wallet is empty (#438)
* feat: introduce amplitude (#440)
* feat: fix denom ibc in staking assets dropdown (#448)
* St 565 val page staking rewards (#447)
* Show disabled network name and icon (#454)
* ST-492: wallet-kit integration (#418)
* Use new IBC channels (#453)
* Improve LUNC/LUNA IBC detection (#456)
* feat: chain dependent staking functionality (#450)
* feat: St 543 implement amplitude (#455)
* fix ibc token denoms (#460)
* FIX: swap Read component (#461)
* fix kujira factory IBC tokens (#466)

---------

Co-authored-by: Manuel Alessandro Collazo <collazo.manuel6@gmail.com>
Co-authored-by: Joshua Brigati <brigati.joshua@gmail.com>
Co-authored-by: plubber <51789398+ericHgorski@users.noreply.github.com>
Co-authored-by: Terence Lim <terencelimz@gmail.com>
Co-authored-by: Alessandro Candeago <54709706+alecande11@users.noreply.github.com>
mwmerz added a commit that referenced this pull request Jul 25, 2023
* fix: property undefined chainID error
* fix: convert object error
* fixed wallet popover overlapping on top of Send and Recieve title ST-475 (#436)
* fix: add scroll to chainlist container (#437)
* feat: filter out non-whitelisted tokens (#439)
* feat: disable send if wallet is empty (#438)
* feat: disable send if wallet is empty
* Co-authored-by: Manuel Alessandro Collazo <collazo.manuel6@gmail.com>

* feat: lunc display
* feat: introduce amplitude (#440)
* feat: introduce amplitude
* feat: fix denom ibc in staking assets dropdown (#448)
* feat: fix denom ibc in staking assets dropdown
* feat: fix denom ibc in staking assets dropdown 2
* revert: denom undefined default value
* fix: add spacing

---------

Co-authored-by: Manuel Alessandro Collazo <collazo.manuel6@gmail.com>

* St 565 val page staking rewards (#447)

* feat: fix val page staking rewards

* Fix scenario whereby proposal with empty description result in error

* Show disabled network name and icon (#454)

* ST-492: wallet-kit integration (#418)

* Use new IBC channels (#453)

* Improve LUNC/LUNA IBC detection (#456)

* fix ibc lunc

* fix readNativeDenom()

* fix undefined chainID

* Use chainID to map unknownIBCDenoms

* fix ts error

* feat: chain dependent staking functionality (#450)

* wip: neutron chain integation

* wip: use network by chain feature

* feat: chain dependent staking functionality

* chore: revert local url

* chore: remove unused imports

* feat: St 543 implement amplitude (#455)

* wip: amplitude tracking revisions

* feat: amplitude setup and tx event track

* fix: add versioning to amplitude client

* chore: fix versioning

* fix: price calculation

Fixing issue with being unable to click withdraw rewards when there are rewards available.

* chore: update package-lock.json

* fix ibc token denoms (#460)

* FIX: swap Read component (#461)

* fix swap Read component

* show 0 if integer is undefined

* show % if there are no decimals

* fix: undefined prices

`ncheq` not available in price list.  Protect against denoms not being available in memoizedPrices.

* Fix ICS20 send back

* fix ICS20 denom calculation

* fix kujira factory IBC tokens (#466)

* fix kujira factory IBC tokens

* fix send back and use prefix to detect kujira

* feat: validate amount inputs (#465)

* feat: validate number fields in amount inputs

* fix: hide input spin button

* fix: unintended form validation

* chore: rem kado buy button (#467)

* chore: rem rewards weight from stake table (#468)

* chore: rem rewards weight from stake table

* fix: rem rewards rate from 2 other places

* chore: added more spacing on the Quick Stake table

---------

Co-authored-by: Joshua <joshua.brigati@gmail.com>

* fix: pass decimals in fee estimation (#471)

* St 619 localterra fix (#469)

* localterra setup

* improve hot reload speed, add env vars in constants

* update preconfigured wallets

* update package.json scripts

* Update preconfigured.json

* fix merge

* add network scan to localterra

* restore src/config/preconfigured.json orig state

* chore(deps): bump semver from 7.3.7 to 7.5.2 (#444)

Bumps [semver](https://github.com/npm/node-semver) from 7.3.7 to 7.5.2.
- [Release notes](https://github.com/npm/node-semver/releases)
- [Changelog](https://github.com/npm/node-semver/blob/main/CHANGELOG.md)
- [Commits](npm/node-semver@v7.3.7...v7.5.2)

---
updated-dependencies:
- dependency-name: semver
  dependency-type: direct:production
...

Signed-off-by: dependabot[bot] <support@github.com>
Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com>

* chore(deps): bump tough-cookie from 4.0.0 to 4.1.3 (#462)

Bumps [tough-cookie](https://github.com/salesforce/tough-cookie) from 4.0.0 to 4.1.3.
- [Release notes](https://github.com/salesforce/tough-cookie/releases)
- [Changelog](https://github.com/salesforce/tough-cookie/blob/master/CHANGELOG.md)
- [Commits](salesforce/tough-cookie@v4.0.0...v4.1.3)

---
updated-dependencies:
- dependency-name: tough-cookie
  dependency-type: indirect
...

Signed-off-by: dependabot[bot] <support@github.com>
Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com>

* chore(deps-dev): bump word-wrap from 1.2.3 to 1.2.4 (#474)

* chore(deps-dev): bump word-wrap from 1.2.3 to 1.2.4

Bumps [word-wrap](https://github.com/jonschlinkert/word-wrap) from 1.2.3 to 1.2.4.
- [Release notes](https://github.com/jonschlinkert/word-wrap/releases)
- [Commits](jonschlinkert/word-wrap@1.2.3...1.2.4)

---
updated-dependencies:
- dependency-name: word-wrap
  dependency-type: indirect
...

Signed-off-by: dependabot[bot] <support@github.com>

---------

Signed-off-by: dependabot[bot] <support@github.com>
Co-authored-by: Mike <17463738+mwmerz@users.noreply.github.com>

* fix: allow decimals in swap (#477)
* St 505 fix history pagination with cosmos sdk 46 (#475)
* wip: use new pagination keys for terra only.
* feat: lower history limit to 75
* Revert "chore: rem kado buy button (#467)"

This reverts commit db138e5.

---------

Signed-off-by: dependabot[bot] <support@github.com>
Co-authored-by: Manuel Alessandro Collazo <collazo.manuel6@gmail.com>
Co-authored-by: Joshua Brigati <brigati.joshua@gmail.com>
Co-authored-by: plubber <51789398+ericHgorski@users.noreply.github.com>
Co-authored-by: Terence Lim <terencelimz@gmail.com>
Co-authored-by: Alessandro Candeago <54709706+alecande11@users.noreply.github.com>
Co-authored-by: Joshua <joshua.brigati@gmail.com>
Co-authored-by: Greg Junge <greg@terra.money>
Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com>
mwmerz added a commit that referenced this pull request Jul 31, 2023
* fixed wallet popover overlapping on top of Send and Recieve title ST-475 (#436)
* fix: add scroll to chainlist container (#437)
* feat: filter out non-whitelisted tokens (#439)
* feat: disable send if wallet is empty (#438)
* feat: introduce amplitude (#440)
* feat: fix denom ibc in staking assets dropdown (#448)
* St 565 val page staking rewards (#447)
* Show disabled network name and icon (#454)
* ST-492: wallet-kit integration (#418)
* Use new IBC channels (#453)
* Improve LUNC/LUNA IBC detection (#456)
* feat: chain dependent staking functionality (#450)
* feat: St 543 implement amplitude (#455)
* fix ibc token denoms (#460)
* FIX: swap Read component (#461)
* fix kujira factory IBC tokens (#466)

---------

Co-authored-by: Manuel Alessandro Collazo <collazo.manuel6@gmail.com>
Co-authored-by: Joshua Brigati <brigati.joshua@gmail.com>
Co-authored-by: plubber <51789398+ericHgorski@users.noreply.github.com>
Co-authored-by: Terence Lim <terencelimz@gmail.com>
Co-authored-by: Alessandro Candeago <54709706+alecande11@users.noreply.github.com>
mwmerz added a commit that referenced this pull request Jul 31, 2023
* fix: property undefined chainID error
* fix: convert object error
* fixed wallet popover overlapping on top of Send and Recieve title ST-475 (#436)
* fix: add scroll to chainlist container (#437)
* feat: filter out non-whitelisted tokens (#439)
* feat: disable send if wallet is empty (#438)
* feat: disable send if wallet is empty
* Co-authored-by: Manuel Alessandro Collazo <collazo.manuel6@gmail.com>

* feat: lunc display
* feat: introduce amplitude (#440)
* feat: introduce amplitude
* feat: fix denom ibc in staking assets dropdown (#448)
* feat: fix denom ibc in staking assets dropdown
* feat: fix denom ibc in staking assets dropdown 2
* revert: denom undefined default value
* fix: add spacing

---------

Co-authored-by: Manuel Alessandro Collazo <collazo.manuel6@gmail.com>

* St 565 val page staking rewards (#447)

* feat: fix val page staking rewards

* Fix scenario whereby proposal with empty description result in error

* Show disabled network name and icon (#454)

* ST-492: wallet-kit integration (#418)

* Use new IBC channels (#453)

* Improve LUNC/LUNA IBC detection (#456)

* fix ibc lunc

* fix readNativeDenom()

* fix undefined chainID

* Use chainID to map unknownIBCDenoms

* fix ts error

* feat: chain dependent staking functionality (#450)

* wip: neutron chain integation

* wip: use network by chain feature

* feat: chain dependent staking functionality

* chore: revert local url

* chore: remove unused imports

* feat: St 543 implement amplitude (#455)

* wip: amplitude tracking revisions

* feat: amplitude setup and tx event track

* fix: add versioning to amplitude client

* chore: fix versioning

* fix: price calculation

Fixing issue with being unable to click withdraw rewards when there are rewards available.

* chore: update package-lock.json

* fix ibc token denoms (#460)

* FIX: swap Read component (#461)

* fix swap Read component

* show 0 if integer is undefined

* show % if there are no decimals

* fix: undefined prices

`ncheq` not available in price list.  Protect against denoms not being available in memoizedPrices.

* Fix ICS20 send back

* fix ICS20 denom calculation

* fix kujira factory IBC tokens (#466)

* fix kujira factory IBC tokens

* fix send back and use prefix to detect kujira

* feat: validate amount inputs (#465)

* feat: validate number fields in amount inputs

* fix: hide input spin button

* fix: unintended form validation

* chore: rem kado buy button (#467)

* chore: rem rewards weight from stake table (#468)

* chore: rem rewards weight from stake table

* fix: rem rewards rate from 2 other places

* chore: added more spacing on the Quick Stake table

---------

Co-authored-by: Joshua <joshua.brigati@gmail.com>

* fix: pass decimals in fee estimation (#471)

* St 619 localterra fix (#469)

* localterra setup

* improve hot reload speed, add env vars in constants

* update preconfigured wallets

* update package.json scripts

* Update preconfigured.json

* fix merge

* add network scan to localterra

* restore src/config/preconfigured.json orig state

* chore(deps): bump semver from 7.3.7 to 7.5.2 (#444)

Bumps [semver](https://github.com/npm/node-semver) from 7.3.7 to 7.5.2.
- [Release notes](https://github.com/npm/node-semver/releases)
- [Changelog](https://github.com/npm/node-semver/blob/main/CHANGELOG.md)
- [Commits](npm/node-semver@v7.3.7...v7.5.2)

---
updated-dependencies:
- dependency-name: semver
  dependency-type: direct:production
...

Signed-off-by: dependabot[bot] <support@github.com>
Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com>

* chore(deps): bump tough-cookie from 4.0.0 to 4.1.3 (#462)

Bumps [tough-cookie](https://github.com/salesforce/tough-cookie) from 4.0.0 to 4.1.3.
- [Release notes](https://github.com/salesforce/tough-cookie/releases)
- [Changelog](https://github.com/salesforce/tough-cookie/blob/master/CHANGELOG.md)
- [Commits](salesforce/tough-cookie@v4.0.0...v4.1.3)

---
updated-dependencies:
- dependency-name: tough-cookie
  dependency-type: indirect
...

Signed-off-by: dependabot[bot] <support@github.com>
Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com>

* chore(deps-dev): bump word-wrap from 1.2.3 to 1.2.4 (#474)

* chore(deps-dev): bump word-wrap from 1.2.3 to 1.2.4

Bumps [word-wrap](https://github.com/jonschlinkert/word-wrap) from 1.2.3 to 1.2.4.
- [Release notes](https://github.com/jonschlinkert/word-wrap/releases)
- [Commits](jonschlinkert/word-wrap@1.2.3...1.2.4)

---
updated-dependencies:
- dependency-name: word-wrap
  dependency-type: indirect
...

Signed-off-by: dependabot[bot] <support@github.com>

---------

Signed-off-by: dependabot[bot] <support@github.com>
Co-authored-by: Mike <17463738+mwmerz@users.noreply.github.com>

* fix: allow decimals in swap (#477)
* St 505 fix history pagination with cosmos sdk 46 (#475)
* wip: use new pagination keys for terra only.
* feat: lower history limit to 75
* Revert "chore: rem kado buy button (#467)"

This reverts commit db138e5.

---------

Signed-off-by: dependabot[bot] <support@github.com>
Co-authored-by: Manuel Alessandro Collazo <collazo.manuel6@gmail.com>
Co-authored-by: Joshua Brigati <brigati.joshua@gmail.com>
Co-authored-by: plubber <51789398+ericHgorski@users.noreply.github.com>
Co-authored-by: Terence Lim <terencelimz@gmail.com>
Co-authored-by: Alessandro Candeago <54709706+alecande11@users.noreply.github.com>
Co-authored-by: Joshua <joshua.brigati@gmail.com>
Co-authored-by: Greg Junge <greg@terra.money>
Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants