feat: validate amount inputs #465
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Deploying with
|
| Latest commit: |
c332b22
|
| Status: | ✅ Deploy successful! |
| Preview URL: | https://f16af26a.station-1a1.pages.dev |
| Branch Preview URL: | https://st-564-fix-inputs.station-1a1.pages.dev |
terran6
previously requested changes
Jul 12, 2023
|
There is a weird up/down selector thing now which we should remove |
Should be fixed now @terencelimzhengwei! Ill apply the same to extension. |
terran6
suggested changes
Jul 12, 2023
good catch, should be solved now. |
terran6
approved these changes
Jul 13, 2023
Merged
mwmerz
added a commit
that referenced
this pull request
Jul 25, 2023
* fix: property undefined chainID error * fix: convert object error * fixed wallet popover overlapping on top of Send and Recieve title ST-475 (#436) * fix: add scroll to chainlist container (#437) * feat: filter out non-whitelisted tokens (#439) * feat: disable send if wallet is empty (#438) * feat: disable send if wallet is empty * Co-authored-by: Manuel Alessandro Collazo <collazo.manuel6@gmail.com> * feat: lunc display * feat: introduce amplitude (#440) * feat: introduce amplitude * feat: fix denom ibc in staking assets dropdown (#448) * feat: fix denom ibc in staking assets dropdown * feat: fix denom ibc in staking assets dropdown 2 * revert: denom undefined default value * fix: add spacing --------- Co-authored-by: Manuel Alessandro Collazo <collazo.manuel6@gmail.com> * St 565 val page staking rewards (#447) * feat: fix val page staking rewards * Fix scenario whereby proposal with empty description result in error * Show disabled network name and icon (#454) * ST-492: wallet-kit integration (#418) * Use new IBC channels (#453) * Improve LUNC/LUNA IBC detection (#456) * fix ibc lunc * fix readNativeDenom() * fix undefined chainID * Use chainID to map unknownIBCDenoms * fix ts error * feat: chain dependent staking functionality (#450) * wip: neutron chain integation * wip: use network by chain feature * feat: chain dependent staking functionality * chore: revert local url * chore: remove unused imports * feat: St 543 implement amplitude (#455) * wip: amplitude tracking revisions * feat: amplitude setup and tx event track * fix: add versioning to amplitude client * chore: fix versioning * fix: price calculation Fixing issue with being unable to click withdraw rewards when there are rewards available. * chore: update package-lock.json * fix ibc token denoms (#460) * FIX: swap Read component (#461) * fix swap Read component * show 0 if integer is undefined * show % if there are no decimals * fix: undefined prices `ncheq` not available in price list. Protect against denoms not being available in memoizedPrices. * Fix ICS20 send back * fix ICS20 denom calculation * fix kujira factory IBC tokens (#466) * fix kujira factory IBC tokens * fix send back and use prefix to detect kujira * feat: validate amount inputs (#465) * feat: validate number fields in amount inputs * fix: hide input spin button * fix: unintended form validation * chore: rem kado buy button (#467) * chore: rem rewards weight from stake table (#468) * chore: rem rewards weight from stake table * fix: rem rewards rate from 2 other places * chore: added more spacing on the Quick Stake table --------- Co-authored-by: Joshua <joshua.brigati@gmail.com> * fix: pass decimals in fee estimation (#471) * St 619 localterra fix (#469) * localterra setup * improve hot reload speed, add env vars in constants * update preconfigured wallets * update package.json scripts * Update preconfigured.json * fix merge * add network scan to localterra * restore src/config/preconfigured.json orig state * chore(deps): bump semver from 7.3.7 to 7.5.2 (#444) Bumps [semver](https://github.com/npm/node-semver) from 7.3.7 to 7.5.2. - [Release notes](https://github.com/npm/node-semver/releases) - [Changelog](https://github.com/npm/node-semver/blob/main/CHANGELOG.md) - [Commits](npm/node-semver@v7.3.7...v7.5.2) --- updated-dependencies: - dependency-name: semver dependency-type: direct:production ... Signed-off-by: dependabot[bot] <support@github.com> Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com> * chore(deps): bump tough-cookie from 4.0.0 to 4.1.3 (#462) Bumps [tough-cookie](https://github.com/salesforce/tough-cookie) from 4.0.0 to 4.1.3. - [Release notes](https://github.com/salesforce/tough-cookie/releases) - [Changelog](https://github.com/salesforce/tough-cookie/blob/master/CHANGELOG.md) - [Commits](salesforce/tough-cookie@v4.0.0...v4.1.3) --- updated-dependencies: - dependency-name: tough-cookie dependency-type: indirect ... Signed-off-by: dependabot[bot] <support@github.com> Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com> * chore(deps-dev): bump word-wrap from 1.2.3 to 1.2.4 (#474) * chore(deps-dev): bump word-wrap from 1.2.3 to 1.2.4 Bumps [word-wrap](https://github.com/jonschlinkert/word-wrap) from 1.2.3 to 1.2.4. - [Release notes](https://github.com/jonschlinkert/word-wrap/releases) - [Commits](jonschlinkert/word-wrap@1.2.3...1.2.4) --- updated-dependencies: - dependency-name: word-wrap dependency-type: indirect ... Signed-off-by: dependabot[bot] <support@github.com> --------- Signed-off-by: dependabot[bot] <support@github.com> Co-authored-by: Mike <17463738+mwmerz@users.noreply.github.com> * fix: allow decimals in swap (#477) * St 505 fix history pagination with cosmos sdk 46 (#475) * wip: use new pagination keys for terra only. * feat: lower history limit to 75 * Revert "chore: rem kado buy button (#467)" This reverts commit db138e5. --------- Signed-off-by: dependabot[bot] <support@github.com> Co-authored-by: Manuel Alessandro Collazo <collazo.manuel6@gmail.com> Co-authored-by: Joshua Brigati <brigati.joshua@gmail.com> Co-authored-by: plubber <51789398+ericHgorski@users.noreply.github.com> Co-authored-by: Terence Lim <terencelimz@gmail.com> Co-authored-by: Alessandro Candeago <54709706+alecande11@users.noreply.github.com> Co-authored-by: Joshua <joshua.brigati@gmail.com> Co-authored-by: Greg Junge <greg@terra.money> Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com>
mwmerz
added a commit
that referenced
this pull request
Jul 31, 2023
* fix: property undefined chainID error * fix: convert object error * fixed wallet popover overlapping on top of Send and Recieve title ST-475 (#436) * fix: add scroll to chainlist container (#437) * feat: filter out non-whitelisted tokens (#439) * feat: disable send if wallet is empty (#438) * feat: disable send if wallet is empty * Co-authored-by: Manuel Alessandro Collazo <collazo.manuel6@gmail.com> * feat: lunc display * feat: introduce amplitude (#440) * feat: introduce amplitude * feat: fix denom ibc in staking assets dropdown (#448) * feat: fix denom ibc in staking assets dropdown * feat: fix denom ibc in staking assets dropdown 2 * revert: denom undefined default value * fix: add spacing --------- Co-authored-by: Manuel Alessandro Collazo <collazo.manuel6@gmail.com> * St 565 val page staking rewards (#447) * feat: fix val page staking rewards * Fix scenario whereby proposal with empty description result in error * Show disabled network name and icon (#454) * ST-492: wallet-kit integration (#418) * Use new IBC channels (#453) * Improve LUNC/LUNA IBC detection (#456) * fix ibc lunc * fix readNativeDenom() * fix undefined chainID * Use chainID to map unknownIBCDenoms * fix ts error * feat: chain dependent staking functionality (#450) * wip: neutron chain integation * wip: use network by chain feature * feat: chain dependent staking functionality * chore: revert local url * chore: remove unused imports * feat: St 543 implement amplitude (#455) * wip: amplitude tracking revisions * feat: amplitude setup and tx event track * fix: add versioning to amplitude client * chore: fix versioning * fix: price calculation Fixing issue with being unable to click withdraw rewards when there are rewards available. * chore: update package-lock.json * fix ibc token denoms (#460) * FIX: swap Read component (#461) * fix swap Read component * show 0 if integer is undefined * show % if there are no decimals * fix: undefined prices `ncheq` not available in price list. Protect against denoms not being available in memoizedPrices. * Fix ICS20 send back * fix ICS20 denom calculation * fix kujira factory IBC tokens (#466) * fix kujira factory IBC tokens * fix send back and use prefix to detect kujira * feat: validate amount inputs (#465) * feat: validate number fields in amount inputs * fix: hide input spin button * fix: unintended form validation * chore: rem kado buy button (#467) * chore: rem rewards weight from stake table (#468) * chore: rem rewards weight from stake table * fix: rem rewards rate from 2 other places * chore: added more spacing on the Quick Stake table --------- Co-authored-by: Joshua <joshua.brigati@gmail.com> * fix: pass decimals in fee estimation (#471) * St 619 localterra fix (#469) * localterra setup * improve hot reload speed, add env vars in constants * update preconfigured wallets * update package.json scripts * Update preconfigured.json * fix merge * add network scan to localterra * restore src/config/preconfigured.json orig state * chore(deps): bump semver from 7.3.7 to 7.5.2 (#444) Bumps [semver](https://github.com/npm/node-semver) from 7.3.7 to 7.5.2. - [Release notes](https://github.com/npm/node-semver/releases) - [Changelog](https://github.com/npm/node-semver/blob/main/CHANGELOG.md) - [Commits](npm/node-semver@v7.3.7...v7.5.2) --- updated-dependencies: - dependency-name: semver dependency-type: direct:production ... Signed-off-by: dependabot[bot] <support@github.com> Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com> * chore(deps): bump tough-cookie from 4.0.0 to 4.1.3 (#462) Bumps [tough-cookie](https://github.com/salesforce/tough-cookie) from 4.0.0 to 4.1.3. - [Release notes](https://github.com/salesforce/tough-cookie/releases) - [Changelog](https://github.com/salesforce/tough-cookie/blob/master/CHANGELOG.md) - [Commits](salesforce/tough-cookie@v4.0.0...v4.1.3) --- updated-dependencies: - dependency-name: tough-cookie dependency-type: indirect ... Signed-off-by: dependabot[bot] <support@github.com> Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com> * chore(deps-dev): bump word-wrap from 1.2.3 to 1.2.4 (#474) * chore(deps-dev): bump word-wrap from 1.2.3 to 1.2.4 Bumps [word-wrap](https://github.com/jonschlinkert/word-wrap) from 1.2.3 to 1.2.4. - [Release notes](https://github.com/jonschlinkert/word-wrap/releases) - [Commits](jonschlinkert/word-wrap@1.2.3...1.2.4) --- updated-dependencies: - dependency-name: word-wrap dependency-type: indirect ... Signed-off-by: dependabot[bot] <support@github.com> --------- Signed-off-by: dependabot[bot] <support@github.com> Co-authored-by: Mike <17463738+mwmerz@users.noreply.github.com> * fix: allow decimals in swap (#477) * St 505 fix history pagination with cosmos sdk 46 (#475) * wip: use new pagination keys for terra only. * feat: lower history limit to 75 * Revert "chore: rem kado buy button (#467)" This reverts commit db138e5. --------- Signed-off-by: dependabot[bot] <support@github.com> Co-authored-by: Manuel Alessandro Collazo <collazo.manuel6@gmail.com> Co-authored-by: Joshua Brigati <brigati.joshua@gmail.com> Co-authored-by: plubber <51789398+ericHgorski@users.noreply.github.com> Co-authored-by: Terence Lim <terencelimz@gmail.com> Co-authored-by: Alessandro Candeago <54709706+alecande11@users.noreply.github.com> Co-authored-by: Joshua <joshua.brigati@gmail.com> Co-authored-by: Greg Junge <greg@terra.money> Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
amount inputs should only accept number characters and
.