New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Check rlpx for EIP-8 compliance #109

Closed

kdeme opened this issue Oct 21, 2019 · 2 comments

Labels

rlpx

Contributor

kdeme commented Oct 21, 2019

Check if rlpx complies with EIP-8 and create unit tests with these test vectors:
https://github.com/ethereum/EIPs/blob/master/EIPS/eip-8.md#test-vectors

This was done already for the discovery part.

kdeme added the rlpx label

kdeme mentioned this issue

TODO list related to Status nim integration status-im/nimbus-eth1#406

Closed

27 tasks

Contributor

cheatfate commented Oct 21, 2019

This two procedures are already supporting EIP-8 authentication and perform it transparently.
https://github.com/status-im/nim-eth/blob/master/eth/p2p/auth.nim#L436
https://github.com/status-im/nim-eth/blob/master/eth/p2p/auth.nim#L456

Test vectors from link you mentioned already in test suite.
https://github.com/status-im/nim-eth/blob/master/tests/p2p/test_auth.nim#L95-L96

Contributor Author

kdeme commented Oct 22, 2019

Oh that's great! I should have known that you would have looked into that :)

I did add one little check that seems to be forgotten: #112

kdeme mentioned this issue

Rlpx unittest #113

Merged

kdeme closed this as completed

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment