Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Rlpx unittest #113

Merged
merged 3 commits into from
Oct 23, 2019
Merged

Rlpx unittest #113

merged 3 commits into from
Oct 23, 2019

Conversation

kdeme
Copy link
Contributor

@kdeme kdeme commented Oct 22, 2019

Basic rlpx thunk unittests, currently containing payloads of previously triggered crashes + the EIP-8 payload (for #109).

@kdeme
Copy link
Contributor Author

kdeme commented Oct 22, 2019

Also changed the msgId to int32 to be the same for x64 & x86 (test originally failed on x86). I don't think we need int64 as I think int32 should be big enough, but we could always change to int64.

@kdeme kdeme requested a review from zah October 22, 2019 15:47
@zah zah merged commit 98be627 into master Oct 23, 2019
@delete-merged-branch delete-merged-branch bot deleted the rlpx-unittest2 branch October 23, 2019 00:35
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants