rename DepositTreeSnapshot -> DepositContractSnapshot
#6036
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
EIP-4881 was never correctly implemented, the `DepositTreeSnapshot` structure has nothing to do with its actual definition. Reflect that by renaming the type to a Nimbus-specific `DepositContractSnapshot`, so that an actual EIP-4881 implementation can use the correct names. - https://eips.ethereum.org/EIPS/eip-4881#specification Notably, `DepositTreeSnapshot` contains a compressed sequence in `finalized`, only containing the minimally required intermediate roots. That also explains the incorrect REST response reported in #5508. The non-canonical representation was introduced in #4303 and is also persisted in the database. We'll have to maintain it for a while.
Closed
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
EIP-4881 was never correctly implemented, the
DepositTreeSnapshotstructure has nothing to do with its actual definition. Reflect that by renaming the type to a Nimbus-specificDepositContractSnapshot, so that an actual EIP-4881 implementation can use the correct names.Notably,
DepositTreeSnapshotcontains a compressed sequence infinalized, only containing the minimally required intermediate roots.That also explains the incorrect REST response reported in #5508.
The non-canonical representation was introduced in #4303 and is also persisted in the database. We'll have to maintain it for a while.