Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

rename DepositTreeSnapshot -> DepositContractSnapshot #6036

Merged
merged 1 commit into from
Mar 7, 2024

Commits on Mar 7, 2024

  1. rename DepositTreeSnapshot -> DepositContractSnapshot

    EIP-4881 was never correctly implemented, the `DepositTreeSnapshot`
    structure has nothing to do with its actual definition. Reflect that
    by renaming the type to a Nimbus-specific `DepositContractSnapshot`,
    so that an actual EIP-4881 implementation can use the correct names.
    
    - https://eips.ethereum.org/EIPS/eip-4881#specification
    
    Notably, `DepositTreeSnapshot` contains a compressed sequence in
    `finalized`, only containing the minimally required intermediate roots.
    
    That also explains the incorrect REST response reported in #5508.
    
    The non-canonical representation was introduced in #4303 and is also
    persisted in the database. We'll have to maintain it for a while.
    etan-status committed Mar 7, 2024
    Configuration menu
    Copy the full SHA
    d1c8a1d View commit details
    Browse the repository at this point in the history