Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Not possible to send community asset with decimal points specified #14074

Closed
anastasiyaig opened this issue Mar 21, 2024 · 1 comment · Fixed by #14126
Closed

Not possible to send community asset with decimal points specified #14074

anastasiyaig opened this issue Mar 21, 2024 · 1 comment · Fixed by #14126
Assignees
@stefandunca
Labels
bug Something isn't working
Milestone
2.29.0 Beta

Comments

@anastasiyaig
Copy link
Contributor

Description

https://sepolia-optimism.etherscan.io/tx/0x1012f175b0fef7fd541dbdcf6ff04c0fbb668ecece5fdfc5e66e5dcaeadf9a40

Screen.Recording.2024-03-21.at.13.38.44.mov
@anastasiyaig anastasiyaig added bug Something isn't working wallet-team labels Mar 21, 2024
@anastasiyaig anastasiyaig added this to the 2.29.0 Beta milestone Mar 21, 2024
stefandunca added a commit that referenced this issue Mar 22, 2024
@stefandunca
fix(wallet) sending community tokens doesn't work
7e5c205 
The contract address is not resolved for the community tokens because
of symbol usage which is not resolved by getTokenBySymbolByTokensKey
- [ ] use tokensKey to identify the token
- [ ] resolve the contract address

Closes #14074
@stefandunca stefandunca mentioned this issue Mar 22, 2024
Merged
@stefandunca
Copy link
Contributor

Found the root cause for community tokens not working. The tokens is sent as a contract deployment (to is 0x0), not sure how come I missed this. It seems the symbol won't resolve to a contract address due to differences in how identify tokens. I have to move the implementation to use tokensKey, I checked that is available in UI which I will do next.

@alaibe alaibe modified the milestones: 2.29.0 Beta, 2.28.1 Beta Mar 25, 2024
stefandunca added a commit that referenced this issue Mar 25, 2024
@stefandunca
fix(wallet) sending community tokens doesn't work
2985068 
The contract address is not resolved for the community tokens because
of symbol usage which is not resolved by getTokenBySymbolByTokensKey
Changes from using symbol to always using tokensKey to identify the
token for all non-native transfers.

Closes #14074
stefandunca added a commit that referenced this issue Mar 25, 2024
@stefandunca
fix(wallet) sending community tokens doesn't work
37efaca 
The contract address is not resolved for the community tokens because
of symbol usage which is not resolved by getTokenBySymbolByTokensKey
Changes from using symbol to always using tokensKey to identify the
token for all non-native transfers.

Closes #14074
stefandunca added a commit that referenced this issue Mar 25, 2024
@stefandunca
fix(wallet) sending community tokens doesn't work
721b72b 
The contract address is not resolved for the community tokens because
of symbol usage which is not resolved by getTokenBySymbolByTokensKey
Changes from using symbol to always using tokensKey to identify the
token for all non-native transfers.

Closes #14074
@iurimatias iurimatias modified the milestones: 2.28.1 Beta, 2.29.0 Beta Mar 25, 2024
stefandunca added a commit that referenced this issue Mar 27, 2024
@stefandunca
fix(wallet) sending community tokens doesn't work
d9a0f46 
The contract address is not resolved for the community tokens because
of symbol usage which is not resolved by getTokenBySymbolByTokensKey
Changes from using symbol to always using tokensKey to identify the
token for all non-native transfers.

Closes #14074
stefandunca added a commit that referenced this issue Mar 27, 2024
@stefandunca
fix(wallet) sending community tokens doesn't work
dd1db75 
The contract address is not resolved for the community tokens because
of symbol usage which is not resolved by getTokenBySymbolByTokensKey
Changes from using symbol to always using tokensKey to identify the
token for all non-native transfers.

Closes #14074
stefandunca added a commit that referenced this issue Mar 28, 2024
@stefandunca
fix(wallet) sending community tokens doesn't work
48c0507 
The contract address is not resolved for the community tokens because
of symbol usage to identify assets. The symbol is not resolved by
`getTokenBySymbolByTokensKey`.
This fix changes from using symbol to always using assetKey to identify
the token for all non-native and non-collectibles transfers.

Closes #14074
stefandunca added a commit that referenced this issue Apr 3, 2024
@stefandunca
fix(wallet) sending community tokens doesn't work
65791a8 
The contract address is not resolved for the community tokens because
of symbol usage to identify assets. The symbol is not resolved by
`getTokenBySymbolByTokensKey`.
This fix changes from using symbol to always using assetKey to identify
the token for all non-native and non-collectibles transfers.

Closes #14074
@github-project-automation github-project-automation bot moved this from In Progress to Done in Status Desktop/Mobile Board Apr 3, 2024
stefandunca added a commit that referenced this issue Apr 18, 2024
@stefandunca
fix(wallet) sending community tokens doesn't work
357ed19 
The contract address is not resolved for the community tokens because
of symbol usage to identify assets. The symbol is not resolved by
`getTokenBySymbolByTokensKey`.
This fix changes from using symbol to always using assetKey to identify
the token for all non-native and non-collectibles transfers.

Closes #14074
jrainville pushed a commit that referenced this issue Apr 19, 2024
@stefandunca @jrainville
fix(wallet) sending community tokens doesn't work
36d8a33 
The contract address is not resolved for the community tokens because
of symbol usage to identify assets. The symbol is not resolved by
`getTokenBySymbolByTokensKey`.
This fix changes from using symbol to always using assetKey to identify
the token for all non-native and non-collectibles transfers.

Closes #14074
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@stefandunca stefandunca

Labels
bug Something isn't working
Projects
Status Desktop/Mobile Board
Archived in project
Milestone
2.29.0 Beta
Development

Successfully merging a pull request may close this issue.

fix(wallet) sending community tokens doesn't work status-im/status-desktop
4 participants
@iurimatias @alaibe @stefandunca @anastasiyaig