fix(wallet) sending community tokens doesn't work #14126
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Jenkins BuildsClick to see older builds (16)
|
stefandunca
force-pushed
the
fix_token_send-14074
branch
from
7e5c205 to
2985068
Compare
stefandunca
force-pushed
the
fix_token_send-14074
branch
2 times, most recently
from
37efaca to
721b72b
Compare
stefandunca
requested review from
dlipicar,
Khushboo-dev-cpp,
Cuteivist and
alaibe
stefandunca
force-pushed
the
fix_token_send-14074
branch
2 times, most recently
from
d9a0f46 to
dd1db75
Compare
dlipicar
reviewed
Mar 27, 2024
dlipicar
reviewed
Mar 27, 2024
dlipicar
reviewed
Mar 27, 2024
The contract address is not resolved for the community tokens because of symbol usage to identify assets. The symbol is not resolved by `getTokenBySymbolByTokensKey`. This fix changes from using symbol to always using assetKey to identify the token for all non-native and non-collectibles transfers. Closes #14074
stefandunca
force-pushed
the
fix_token_send-14074
branch
from
dd1db75 to
48c0507
Compare
dlipicar
reviewed
Mar 28, 2024
dlipicar
reviewed
Mar 28, 2024
dlipicar
approved these changes
Mar 28, 2024
There was a problem hiding this comment.
There's still some conditions between the sendType and what we expect asset and assetKey to be that are not reflected in the code, but this is a big improvement vs what we had. That should perhaps be part of a bigger rework, split what's common and what's different for each case into smaller, separate functions.
Please test this with ETH, ERC20, ERC721 and ERC1155 transfers.
I could validate that sending all types work after including fixes from here: status-im/status-go#5001 The PR is still blocked by the Windows CI that fails while fetching git submodules, waiting for Infra team to have the availability to fix this. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Closes #14074
The contract address is not resolved for the community tokens because of symbol usage which is not resolved by
getTokenBySymbolByTokensKey.This change switched to always using
tokensKeyto identify the token for all non-native transfers. Basically thetransferTokenalways requires token which guarantees a valid token address.Also remove token lookup redundant code.