New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Can't send collectibles using Send Modal #14212

Closed

stefandunca opened this issue Mar 28, 2024 · 3 comments · Fixed by #14224

Assignees

Labels

bug

Contributor

stefandunca commented Mar 28, 2024

Steps to reproduce

stefandunca added the bug label

stefandunca self-assigned this

github-project-automation bot added this to Status Desktop/Mobile Board

stefandunca added this to Do not use - tasks moved to unified Desktop / Mobile Board

stefandunca moved this to In Progress in Do not use - tasks moved to unified Desktop / Mobile Board

stefandunca added a commit that referenced this issue


          fix(SendModal): fix various issues with SendModal

cfc3c51

- Fix errors when switching between assets and collectibles tabs
  - Fix by controlling the order of instantiation between model and
    delegates not to mix models and delegates from different sources
- Fix size errors
- Various improvements

Updates: #14212

stefandunca mentioned this issue

Fix sending collectibles #14224

Merged

2 tasks

stefandunca added a commit that referenced this issue


          fix(SendModal): fix various issues with SendModal

- Fix errors when switching between assets and collectibles tabs
  - Fix by controlling the order of instantiation between model and
    delegates not to mix models and delegates from different sources
- Fix size errors
- Various improvements

Updates: #14212

stefandunca added a commit that referenced this issue


          test(wallet) add dev integration tests for route estimator

6ff6ec4

Used for debugging ERC721 route estimation issues

Updates: #14212

Contributor Author

stefandunca commented Mar 29, 2024

Debugging now why router doesn't return any result for collectibles. I added an integration test to help debugging.

stefandunca mentioned this issue

fix(wallet) fix ERC721 and ERC1155 transfer router status-im/status-go#5001

Merged

Contributor Author

stefandunca commented Mar 30, 2024

I fixed the router for ERC721 here status-im/status-go#5001

stefandunca moved this from In Progress to Code Review in Do not use - tasks moved to unified Desktop / Mobile Board

stefandunca added a commit that referenced this issue


          fix(wallet) fix erc721 transfer router

548a22e

Closes #14212

stefandunca added a commit that referenced this issue


          fix(wallet) fix erc721 transfer router

ec61eb4

Bump status-go to fix collectible transfer router

Closes #14212

stefandunca added a commit that referenced this issue


          fix(SendModal): fix various issues with SendModal

d2201dd

- Fix errors when switching between assets and collectibles tabs
  - Fix by controlling the order of instantiation between model and
    delegates not to mix models and delegates from different sources
- Fix size errors
- Various improvements

Updates: #14212

stefandunca added a commit that referenced this issue


          test(wallet) add dev integration tests for ERC721 route estimator

Used for debugging ERC721 route estimation issues

Updates: #14212

stefandunca added a commit that referenced this issue


          test(wallet) add dev integration tests for ERC1155 route estimator

f473f0d

Used for debugging ERC1155 route estimation issues

Updates: #14212

stefandunca added a commit that referenced this issue


          fix(wallet) fix erc721 transfer router

941503d

Bump status-go to fix collectible transfer router

Closes #14212

stefandunca added a commit that referenced this issue


          fix(wallet) fix erc721 transfer router

4d96f75

Bump status-go to fix collectible transfer router

Closes #14212

Contributor Author

stefandunca commented Apr 1, 2024

I found that also ERC1155 is broken and added the fix here status-im/status-go#5001.
I tested routing and sending of all types with changes done here and all are fine now.

stefandunca added a commit that referenced this issue


          fix(SendModal): fix various issues with SendModal

74665cb

- Fix errors when switching between assets and collectibles tabs
  - Fix by controlling the order of instantiation between model and
    delegates not to mix models and delegates from different sources
- Fix size errors
- Various improvements

Updates: #14212

stefandunca added a commit that referenced this issue


          test(wallet) add dev integration tests for ERC721 route estimator

ad6cb9b

Used for debugging ERC721 route estimation issues

Updates: #14212

stefandunca added a commit that referenced this issue


          test(wallet) add dev integration tests for ERC1155 route estimator

450bed0

Used for debugging ERC1155 route estimation issues

Updates: #14212

stefandunca added a commit that referenced this issue


          fix(wallet) fix erc721 transfer router

7d0da59

Bump status-go to fix collectible transfer router

Closes #14212

stefandunca added a commit that referenced this issue


          fix(SendModal): fix various issues with SendModal

809e416

- Fix errors when switching between assets and collectibles tabs
  - Fix by controlling the order of instantiation between model and
    delegates not to mix models and delegates from different sources
- Fix size errors
- Various improvements

Updates: #14212

stefandunca added a commit that referenced this issue


          test(wallet) add dev integration tests for ERC721 route estimator

e14ccb9

Used for debugging ERC721 route estimation issues

Updates: #14212

stefandunca added a commit that referenced this issue


          test(wallet) add dev integration tests for ERC1155 route estimator

762d9b0

Used for debugging ERC1155 route estimation issues

Updates: #14212

stefandunca added a commit that referenced this issue


          fix(wallet) fix erc721 transfer router

0b58fa6

Bump status-go to fix collectible transfer router

Closes #14212

stefandunca added a commit that referenced this issue


          fix(SendModal): fix various issues with SendModal

90571ee

- Fix errors when switching between assets and collectibles tabs
  - Fix by controlling the order of instantiation between model and
    delegates not to mix models and delegates from different sources
- Fix size errors
- Various improvements

Updates: #14212

stefandunca added a commit that referenced this issue


          test(wallet) add dev integration tests for ERC721 route estimator

63d3262

Used for debugging ERC721 route estimation issues

Updates: #14212

stefandunca added a commit that referenced this issue


          test(wallet) add dev integration tests for ERC1155 route estimator

fab496e

Used for debugging ERC1155 route estimation issues

Updates: #14212

stefandunca added a commit that referenced this issue


          fix(wallet) fix erc721 transfer router

Bump status-go to fix collectible transfer router

Closes #14212

stefandunca added a commit that referenced this issue


          fix(SendModal): fix various issues with SendModal

e29ea2e

- Fix errors when switching between assets and collectibles tabs
  - Fix by controlling the order of instantiation between model and
    delegates not to mix models and delegates from different sources
- Fix size errors
- Various improvements

Updates: #14212

stefandunca added a commit that referenced this issue


          test(wallet) add dev integration tests for ERC721 route estimator

4661e5c

Used for debugging ERC721 route estimation issues

Updates: #14212

stefandunca added a commit that referenced this issue


          test(wallet) add dev integration tests for ERC1155 route estimator

94be7a3

Used for debugging ERC1155 route estimation issues

Updates: #14212

stefandunca added a commit that referenced this issue


          fix(wallet) fix erc721 transfer router

7efee28

Bump status-go to fix collectible transfer router

Closes #14212

stefandunca closed this as completed in #14224

stefandunca added a commit that referenced this issue


          fix(SendModal): fix various issues with SendModal

ee23cce

- Fix errors when switching between assets and collectibles tabs
  - Fix by controlling the order of instantiation between model and
    delegates not to mix models and delegates from different sources
- Fix size errors
- Various improvements

Updates: #14212

stefandunca added a commit that referenced this issue


          test(wallet) add dev integration tests for ERC721 route estimator

ad0a7d3

Used for debugging ERC721 route estimation issues

Updates: #14212

stefandunca added a commit that referenced this issue


          test(wallet) add dev integration tests for ERC1155 route estimator

7e146d6

Used for debugging ERC1155 route estimation issues

Updates: #14212

stefandunca added a commit that referenced this issue


          fix(wallet) fix erc721 transfer router

21b884e

Bump status-go to fix collectible transfer router

Closes #14212

github-project-automation bot moved this from Code Review to Done in Do not use - tasks moved to unified Desktop / Mobile Board

github-project-automation bot moved this to Done in Status Desktop/Mobile Board

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment