-
Notifications
You must be signed in to change notification settings - Fork 81
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[Onboarding] Integrate the biometrics #17085
Comments
For the integration, this has to be done:
cc @micieslak |
In the UI we have these props in LoginScreen: property bool biometricsAvailable: Qt.platform.os === Constants.mac
property bool isBiometricsLogin // old code: `localAccountSettings.storeToKeychainValue === Constants.keychain.storedValue.store`
// emitted when the user wants to try the biometrics prompt again
signal biometricsRequested() Then we need to figure out the moment/place where to ask the keychain for the credentials. Additionally we should invoke/display the OS biometrics popup again when the user requests it explicitely via the Furthermore, the LoginScreen expects and reacts to these signals coming from the OnboardingStore: // biometrics
signal obtainingPasswordSuccess(string password)
signal obtainingPasswordError(string errorDescription, string errorType /* Constants.keychain.errorType.* */, bool wrongFingerprint) and uses those to either fill the UI with password/pin, or to display an error |
As for the didn't test this: #import <Security/Security.h>
BOOL keychainItemExists(NSString *service, NSString *account) {
NSDictionary *query = @{
(__bridge id)kSecClass: (__bridge id)kSecClassGenericPassword,
(__bridge id)kSecAttrService: service,
(__bridge id)kSecAttrAccount: account,
(__bridge id)kSecReturnAttributes: @NO // Do not return sensitive data
};
OSStatus status = SecItemCopyMatching((__bridge CFDictionaryRef)query, NULL);
return (status == errSecSuccess);
} |
Description
Found here at point 14. #17045 (comment)
The biometrics need to be hooked correctly to the UI
Acceptance Criteria
The text was updated successfully, but these errors were encountered: