Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: Keychain QML Item #17166

Merged
merged 16 commits into from
Feb 4, 2025
Merged

feat: Keychain QML Item #17166

merged 16 commits into from
Feb 4, 2025

Conversation

igor-sirotin
Copy link
Contributor

@igor-sirotin igor-sirotin commented Jan 30, 2025

Required for #17085

Screen.Recording.2025-02-02.at.13.17.28.mov

@status-im-auto
Copy link
Member

status-im-auto commented Jan 30, 2025

Jenkins Builds

Click to see older builds (78)
Commit #️⃣ Finished (UTC) Duration Platform Result
c3c66b8 #1 2025-01-30 10:26:32 ~5 min tests/ui 📄log
✔️ c3c66b8 #1 2025-01-30 10:28:39 ~7 min macos/aarch64 🍎dmg
c3c66b8 #1 2025-01-30 10:29:29 ~8 min linux/x86_64 📄log
c3c66b8 #1 2025-01-30 10:29:40 ~8 min macos/x86_64 📄log
✔️ c3c66b8 #1 2025-01-30 10:30:09 ~8 min tests/nim 📄log
c3c66b8 #1 2025-01-30 10:33:55 ~12 min windows/x86_64 📄log
c3c66b8 #1 2025-01-30 10:33:57 ~12 min linux-nix/x86_64 📄log
453becd #3 2025-01-30 18:07:28 ~4 min tests/ui 📄log
✔️ 453becd #3 2025-01-30 18:10:17 ~7 min macos/aarch64 🍎dmg
453becd #3 2025-01-30 18:10:42 ~7 min linux/x86_64 📄log
5a88732 #4 2025-01-30 18:15:23 ~4 min tests/ui 📄log
✔️ 5a88732 #4 2025-01-30 18:16:16 ~5 min macos/aarch64 🍎dmg
5a88732 #4 2025-01-30 18:16:41 ~5 min macos/x86_64 📄log
5a88732 #4 2025-01-30 18:17:57 ~7 min linux/x86_64 📄log
✔️ 5a88732 #4 2025-01-30 18:19:51 ~9 min tests/nim 📄log
5a88732 #4 2025-01-30 18:21:55 ~11 min windows/x86_64 📄log
5a88732 #4 2025-01-30 18:23:40 ~12 min linux-nix/x86_64 📄log
✔️ 5b1e4f0 #5 2025-01-31 12:34:10 ~5 min macos/aarch64 🍎dmg
5b1e4f0 #5 2025-01-31 12:34:25 ~6 min macos/x86_64 📄log
5b1e4f0 #5 2025-01-31 12:36:16 ~8 min linux/x86_64 📄log
✔️ 5b1e4f0 #5 2025-01-31 12:37:39 ~9 min tests/nim 📄log
5b1e4f0 #5 2025-01-31 12:39:24 ~11 min windows/x86_64 📄log
✔️ 5b1e4f0 #5 2025-01-31 12:42:55 ~14 min tests/ui 📄log
✔️ 5b1e4f0 #5 2025-01-31 12:49:17 ~21 min linux-nix/x86_64 📦tgz
2589d2c #6 2025-01-31 16:02:25 ~3 min macos/aarch64 📄log
2589d2c #6 2025-01-31 16:04:21 ~5 min macos/x86_64 📄log
2589d2c #6 2025-01-31 16:05:25 ~6 min linux/x86_64 📄log
✔️ 2589d2c #6 2025-01-31 16:07:26 ~8 min tests/nim 📄log
2589d2c #6 2025-01-31 16:10:43 ~12 min tests/ui 📄log
✔️ 2589d2c #6 2025-01-31 16:20:41 ~22 min linux-nix/x86_64 📦tgz
✔️ 2589d2c #6 2025-01-31 16:28:13 ~29 min windows/x86_64 💿exe
a39dd35 #7 2025-02-02 11:20:04 ~3 min macos/aarch64 📄log
a39dd35 #7 2025-02-02 11:21:10 ~5 min macos/x86_64 📄log
a39dd35 #7 2025-02-02 11:22:41 ~6 min linux/x86_64 📄log
✔️ a39dd35 #7 2025-02-02 11:25:18 ~9 min tests/nim 📄log
✔️ a39dd35 #7 2025-02-02 11:29:04 ~12 min tests/ui 📄log
✔️ a39dd35 #7 2025-02-02 11:36:09 ~20 min linux-nix/x86_64 📦tgz
✔️ a39dd35 #7 2025-02-02 11:45:32 ~29 min windows/x86_64 💿exe
91a0ad7 #8 2025-02-02 12:45:06 ~2 min macos/aarch64 📄log
91a0ad7 #8 2025-02-02 12:46:57 ~4 min macos/x86_64 📄log
91a0ad7 #8 2025-02-02 12:46:57 ~4 min tests/ui 📄log
91a0ad7 #8 2025-02-02 12:48:11 ~6 min linux/x86_64 📄log
91a0ad7 #8 2025-02-02 12:50:50 ~8 min linux-nix/x86_64 📄log
✔️ 91a0ad7 #8 2025-02-02 12:50:50 ~8 min tests/nim 📄log
91a0ad7 #8 2025-02-02 12:58:05 ~15 min windows/x86_64 📄log
4ff3cda #9 2025-02-02 13:13:59 ~3 min macos/aarch64 📄log
4ff3cda #9 2025-02-02 13:15:17 ~4 min macos/x86_64 📄log
4e0e771 #11 2025-02-02 13:21:06 ~3 min macos/aarch64 📄log
4e0e771 #11 2025-02-02 13:22:00 ~4 min tests/ui 📄log
4e0e771 #11 2025-02-02 13:23:28 ~6 min macos/x86_64 📄log
4e0e771 #11 2025-02-02 13:24:17 ~6 min linux/x86_64 📄log
4e0e771 #11 2025-02-02 13:25:35 ~8 min linux-nix/x86_64 📄log
✔️ 4e0e771 #11 2025-02-02 13:26:03 ~8 min tests/nim 📄log
bbf92d7 #12 2025-02-02 13:30:56 ~3 min macos/aarch64 📄log
bbf92d7 #12 2025-02-02 13:32:00 ~4 min tests/ui 📄log
bbf92d7 #12 2025-02-02 13:32:54 ~5 min macos/x86_64 📄log
bbf92d7 #12 2025-02-02 13:33:28 ~6 min linux/x86_64 📄log
✔️ bbf92d7 #12 2025-02-02 13:35:54 ~8 min tests/nim 📄log
bbf92d7 #12 2025-02-02 13:38:22 ~11 min linux-nix/x86_64 📄log
bbf92d7 #12 2025-02-02 13:38:40 ~11 min windows/x86_64 📄log
d0b9805 #13 2025-02-02 13:45:50 ~4 min macos/x86_64 📄log
✔️ d0b9805 #13 2025-02-02 13:46:09 ~4 min macos/aarch64 🍎dmg
d0b9805 #13 2025-02-02 13:46:26 ~4 min tests/ui 📄log
d0b9805 #13 2025-02-02 13:47:31 ~6 min linux/x86_64 📄log
✔️ 82d84f2 #15 2025-02-02 13:56:47 ~6 min macos/aarch64 🍎dmg
82d84f2 #15 2025-02-02 13:57:40 ~7 min macos/x86_64 📄log
82d84f2 #15 2025-02-02 13:57:59 ~7 min linux/x86_64 📄log
✔️ 82d84f2 #15 2025-02-02 13:59:46 ~9 min tests/nim 📄log
✔️ 82d84f2 #15 2025-02-02 14:02:50 ~12 min tests/ui 📄log
✔️ 82d84f2 #15 2025-02-02 14:09:03 ~18 min linux-nix/x86_64 📦tgz
✔️ 82d84f2 #15 2025-02-02 14:16:10 ~25 min windows/x86_64 💿exe
✔️ 88485e7 #16 2025-02-03 10:55:11 ~5 min macos/aarch64 🍎dmg
88485e7 #16 2025-02-03 10:55:32 ~5 min macos/x86_64 📄log
88485e7 #16 2025-02-03 10:56:00 ~6 min linux/x86_64 📄log
✔️ 88485e7 #16 2025-02-03 10:58:21 ~8 min tests/nim 📄log
✔️ 88485e7 #16 2025-02-03 11:02:25 ~12 min tests/ui 📄log
✔️ 88485e7 #16 2025-02-03 11:09:21 ~19 min linux-nix/x86_64 📦tgz
✔️ 88485e7 #16 2025-02-03 11:16:51 ~27 min windows/x86_64 💿exe
Commit #️⃣ Finished (UTC) Duration Platform Result
64326e3 #19 2025-02-03 11:28:48 ~4 min macos/x86_64 📄log
✔️ 64326e3 #19 2025-02-03 11:29:07 ~4 min macos/aarch64 🍎dmg
64326e3 #19 2025-02-03 11:31:41 ~7 min linux/x86_64 📄log
✔️ 64326e3 #19 2025-02-03 11:32:49 ~8 min tests/nim 📄log
✔️ 64326e3 #19 2025-02-03 11:37:22 ~12 min tests/ui 📄log
✔️ 64326e3 #19 2025-02-03 11:42:06 ~17 min linux-nix/x86_64 📦tgz
✔️ 64326e3 #19 2025-02-03 11:50:17 ~25 min windows/x86_64 💿exe
✔️ bb19837 #20 2025-02-03 13:15:32 ~6 min macos/aarch64 🍎dmg
✔️ bb19837 #20 2025-02-03 13:19:53 ~10 min tests/nim 📄log
✔️ bb19837 #20 2025-02-03 13:22:28 ~12 min macos/x86_64 🍎dmg
bb19837 #20 2025-02-03 13:26:41 ~17 min tests/ui 📄log
✔️ bb19837 #21 2025-02-03 13:27:18 ~17 min linux-nix/x86_64 📦tgz
✔️ bb19837 #20 2025-02-03 13:28:13 ~18 min linux/x86_64 📦tgz
✔️ bb19837 #20 2025-02-03 13:35:20 ~25 min windows/x86_64 💿exe
bb19837 #21 2025-02-03 14:17:29 ~12 min tests/ui 📄log
✔️ bb19837 #22 2025-02-04 11:36:59 ~11 min tests/ui 📄log

@igor-sirotin igor-sirotin force-pushed the feat/keychain-qml-item branch 2 times, most recently from 34e8850 to 453becd Compare January 30, 2025 18:02
@igor-sirotin igor-sirotin force-pushed the feat/keychain-qml-item branch from 453becd to 5a88732 Compare January 30, 2025 18:10
@igor-sirotin igor-sirotin force-pushed the feat/keychain-qml-item branch 2 times, most recently from 87aadf6 to 4e0e771 Compare February 2, 2025 13:17
@igor-sirotin
Copy link
Contributor Author

@caybro you don't have to review unless it's out of draft 🙂

@igor-sirotin igor-sirotin force-pushed the feat/keychain-qml-item branch from f979fda to 82d84f2 Compare February 2, 2025 13:50
Copy link
Member

@micieslak micieslak left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good in general, just some minor technical comments.

@igor-sirotin igor-sirotin force-pushed the feat/keychain-qml-item branch from 2575df8 to 64326e3 Compare February 3, 2025 11:24
@igor-sirotin igor-sirotin marked this pull request as ready for review February 3, 2025 11:27
@igor-sirotin igor-sirotin requested review from alexjba and a team as code owners February 3, 2025 11:27
@igor-sirotin igor-sirotin self-assigned this Feb 3, 2025
@igor-sirotin igor-sirotin added this to the 2.33.0 Beta milestone Feb 3, 2025
@@ -36,6 +36,7 @@ status-desktop.log
nim_status_client.log
*.csv
.flatpak-builder
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Is it related and necessary here?

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@micieslak It's not related.
But I get this shit every time I run the Storybook, and I have to clean it up before committing, quite annoying 😬

@igor-sirotin igor-sirotin force-pushed the feat/keychain-qml-item branch from 64326e3 to bb19837 Compare February 3, 2025 13:09
@igor-sirotin igor-sirotin requested a review from a team as a code owner February 3, 2025 13:09
@igor-sirotin igor-sirotin requested review from Cuteivist and removed request for a team February 3, 2025 13:09
@igor-sirotin igor-sirotin changed the base branch from feat/new-onbaording-login-flows to master February 3, 2025 13:09
Comment on lines +96 to +97
if (m_future.isRunning()) {
return;
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think we should print a warning at least at this point. Calling it when busy means some logical problems on the caller side and shouldn't be just muted.

Copy link
Member

@micieslak micieslak left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

@igor-sirotin
Copy link
Contributor Author

@caybro can you please take a look?

Copy link
Member

@caybro caybro left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

Just a minor detail + pls squash the commits :)

{
Q_UNUSED(account);
qWarning() << "Keychain::requestGetCredential is intended to be called only on MacOS.";
emit getCredentialRequestCompleted(Keychain::StatusNotSupported, "");
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Suggested change
emit getCredentialRequestCompleted(Keychain::StatusNotSupported, "");
emit getCredentialRequestCompleted(Keychain::StatusNotSupported, {});

@@ -0,0 +1,48 @@
#include "StatusQ/keychain.h"

#include <QDebug>
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Not needed here?

@igor-sirotin
Copy link
Contributor Author

pls squash the commits :)

@caybro I always do it with Github
image

@igor-sirotin igor-sirotin merged commit 6e1ef46 into master Feb 4, 2025
9 checks passed
@igor-sirotin igor-sirotin deleted the feat/keychain-qml-item branch February 4, 2025 12:26
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
Status: Done
Development

Successfully merging this pull request may close these issues.

None yet

4 participants